From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LDlUz-0001WT-Ty
	for qemu-devel@nongnu.org; Fri, 19 Dec 2008 14:59:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LDlUy-0001WH-I3
	for qemu-devel@nongnu.org; Fri, 19 Dec 2008 14:59:00 -0500
Received: from [199.232.76.173] (port=40220 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LDlUy-0001WE-CK
	for qemu-devel@nongnu.org; Fri, 19 Dec 2008 14:59:00 -0500
Received: from mail-bw0-f12.google.com ([209.85.218.12]:45413)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LDlUx-0001vs-OB
	for qemu-devel@nongnu.org; Fri, 19 Dec 2008 14:59:00 -0500
Received: by bwz5 with SMTP id 5so185337bwz.10
	for <qemu-devel@nongnu.org>; Fri, 19 Dec 2008 11:58:58 -0800 (PST)
Message-ID: <f43fc5580812191157n3b56d7b6hf6d0e049a64898e@mail.gmail.com>
Date: Fri, 19 Dec 2008 21:57:30 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 5/6] hook cpu_register_physical_mem
In-Reply-To: <1229619702-26315-6-git-send-email-glommer@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1229619702-26315-1-git-send-email-glommer@redhat.com>
	<1229619702-26315-2-git-send-email-glommer@redhat.com>
	<1229619702-26315-3-git-send-email-glommer@redhat.com>
	<1229619702-26315-4-git-send-email-glommer@redhat.com>
	<1229619702-26315-5-git-send-email-glommer@redhat.com>
	<1229619702-26315-6-git-send-email-glommer@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Ian.Jackson@eu.citrix.com, avi@redhat.com, kvm@vger.kernel.org, stefano.stabellini@eu.citrix.com

On 12/18/08, Glauber Costa <glommer@redhat.com> wrote:
> Since now we have our own memory read/write function, we don't
>  depend on all of tcg data structures anymore. So, instead of filling
>  them up, bypass it altogether by using kvm_set_phys mem alone.
>
>  To do that, we now have to provide our own way to get page
>  information given the address. (kvm_get_physical_page_desc)
>
>  Signed-off-by: Glauber Costa <glommer@redhat.com>

>  +static void tcg_register_physical_memory_offset(target_phys_addr_t start_addr,

I don't think TCG actually has much to do with the function. Would
no_kvm be too ugly?

More philosophically, what is (Qemu /\ ~KVM /\ ~TCG)? I hope I got the
math right.