From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LEeIA-0007qv-Ic for qemu-devel@nongnu.org; Mon, 22 Dec 2008 01:29:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LEeI9-0007qY-Vq for qemu-devel@nongnu.org; Mon, 22 Dec 2008 01:29:26 -0500 Received: from [199.232.76.173] (port=40703 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LEeI9-0007qV-GG for qemu-devel@nongnu.org; Mon, 22 Dec 2008 01:29:25 -0500 Received: from mail-bw0-f12.google.com ([209.85.218.12]:50756) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LEeI9-0001qC-AC for qemu-devel@nongnu.org; Mon, 22 Dec 2008 01:29:25 -0500 Received: by bwz5 with SMTP id 5so2675324bwz.10 for ; Sun, 21 Dec 2008 22:29:23 -0800 (PST) Message-ID: Date: Mon, 22 Dec 2008 08:29:22 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] add missing firmware configuration channel numbers to BIOS In-Reply-To: <494ED60F.6000509@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <494ED60F.6000509@amd.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 12/22/08, Andre Przywara wrote: > Hi, > > although we currently don't use firmware config channel > numbers higher than '0x02' in the PC-BIOS, add the channel > names to the BIOS source to mark already used entries. > This will make picking new number easier in the future. Isn't it possible to use fw_cfg.h directly? To get just the constants, you can use NO_QEMU_PROTOS. This is how it is used in OpenBIOS/Sparc64 as an example: http://tracker.coreboot.org/trac/openbios/browser/openbios-devel/arch/sparc64/entry.S#L14 http://tracker.coreboot.org/trac/openbios/browser/openbios-devel/arch/sparc64/openbios.c#L29