qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] add missing firmware configuration channel numbers to BIOS
Date: Mon, 22 Dec 2008 12:34:14 +0200	[thread overview]
Message-ID: <f43fc5580812220234leed0826u47c0ddd6a17c73a1@mail.gmail.com> (raw)
In-Reply-To: <494F5F9E.1020801@amd.com>

On 12/22/08, Andre Przywara <andre.przywara@amd.com> wrote:
> Blue Swirl wrote:
>
> >
> > >
> > >  although we currently don't use firmware config channel
> > >  numbers higher than '0x02' in the PC-BIOS, add the channel
> > >  names to the BIOS source to mark already used entries.
> > >  This will make picking new number easier in the future.
> > >
> >
> > Isn't it possible to use fw_cfg.h directly? To get just the constants,
> > you can use NO_QEMU_PROTOS.
> >
>  Nice idea, but this would require to have the QEMU sources directly
> available when building the BIOS ROM. This is not a real problem, but would
> require to pull in the QEMU source path from the BOCHS autotools Makefile
> (with what default? Revert to the current code if no QEMU source path is
> given?). Currently you can build the BIOS independently with just the QEMU
> patches applied. If you (or Anthony) think this OK, I'd prepare a patch for
> this.

I'd just copy fw_cfg.h to BOCHS directory so that rombios32.c can
include it and remove the current #defines. That way Qemu sources are
not needed.

      reply	other threads:[~2008-12-22 10:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-21 23:49 [Qemu-devel] [PATCH] add missing firmware configuration channel numbers to BIOS Andre Przywara
2008-12-22  6:29 ` Blue Swirl
2008-12-22  9:36   ` Andre Przywara
2008-12-22 10:34     ` Blue Swirl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580812220234leed0826u47c0ddd6a17c73a1@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).