From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LEi79-0006zO-Hd
	for qemu-devel@nongnu.org; Mon, 22 Dec 2008 05:34:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LEi77-0006yr-U2
	for qemu-devel@nongnu.org; Mon, 22 Dec 2008 05:34:19 -0500
Received: from [199.232.76.173] (port=34385 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LEi77-0006yn-KM
	for qemu-devel@nongnu.org; Mon, 22 Dec 2008 05:34:17 -0500
Received: from mail-bw0-f12.google.com ([209.85.218.12]:64994)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LEi76-0004yN-WD
	for qemu-devel@nongnu.org; Mon, 22 Dec 2008 05:34:17 -0500
Received: by bwz5 with SMTP id 5so2893190bwz.10
	for <qemu-devel@nongnu.org>; Mon, 22 Dec 2008 02:34:14 -0800 (PST)
Message-ID: <f43fc5580812220234leed0826u47c0ddd6a17c73a1@mail.gmail.com>
Date: Mon, 22 Dec 2008 12:34:14 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] add missing firmware configuration channel
	numbers to BIOS
In-Reply-To: <494F5F9E.1020801@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <494ED60F.6000509@amd.com>
	<f43fc5580812212229q6bc10785ne84768f99e479383@mail.gmail.com>
	<494F5F9E.1020801@amd.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 12/22/08, Andre Przywara <andre.przywara@amd.com> wrote:
> Blue Swirl wrote:
>
> >
> > >
> > >  although we currently don't use firmware config channel
> > >  numbers higher than '0x02' in the PC-BIOS, add the channel
> > >  names to the BIOS source to mark already used entries.
> > >  This will make picking new number easier in the future.
> > >
> >
> > Isn't it possible to use fw_cfg.h directly? To get just the constants,
> > you can use NO_QEMU_PROTOS.
> >
>  Nice idea, but this would require to have the QEMU sources directly
> available when building the BIOS ROM. This is not a real problem, but would
> require to pull in the QEMU source path from the BOCHS autotools Makefile
> (with what default? Revert to the current code if no QEMU source path is
> given?). Currently you can build the BIOS independently with just the QEMU
> patches applied. If you (or Anthony) think this OK, I'd prepare a patch for
> this.

I'd just copy fw_cfg.h to BOCHS directory so that rombios32.c can
include it and remove the current #defines. That way Qemu sources are
not needed.