From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LFDOg-00079I-VM
	for qemu-devel@nongnu.org; Tue, 23 Dec 2008 14:58:31 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LFDOe-00078q-Dm
	for qemu-devel@nongnu.org; Tue, 23 Dec 2008 14:58:29 -0500
Received: from [199.232.76.173] (port=55628 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LFDOe-00078n-6O
	for qemu-devel@nongnu.org; Tue, 23 Dec 2008 14:58:28 -0500
Received: from mail-fx0-f20.google.com ([209.85.220.20]:63509)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LFDOd-0001VS-NE
	for qemu-devel@nongnu.org; Tue, 23 Dec 2008 14:58:27 -0500
Received: by fxm13 with SMTP id 13so572526fxm.10
	for <qemu-devel@nongnu.org>; Tue, 23 Dec 2008 11:58:26 -0800 (PST)
Message-ID: <f43fc5580812231158l1ed8695h50876927ae0d93da@mail.gmail.com>
Date: Tue, 23 Dec 2008 21:58:26 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack
In-Reply-To: <49513F5C.1010605@gmx.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <937963.51173.qm@web51111.mail.re2.yahoo.com>
	<f43fc5580812231030n7319faedu420bf408004b221a@mail.gmail.com>
	<49513F5C.1010605@gmx.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 12/23/08, Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:
> On 23.12.2008 19:30, Blue Swirl wrote:
>  > On 12/23/08, Justin Chevrier <theburner1@yahoo.com> wrote:
>  >
>  >>  It also appears that the code referenced in the link loops infinitely due to a missing: "max_sensei--;" which is present in the Linux Kernel's equivalent code.
>  >>
>  >
>  > This one:
>  > http://fxr.watson.org/fxr/source/drivers/block/floppy.c?v=linux-2.4.22;im=bigexcerpts#L1800
>  >
>  > Adding max_sensei-- to OpenBIOS allows it to survive your previous
>  > patch, which caused an infinite loop earlier:
>  >
>  > floppy_motor_off
>  > SENSEI c0 00
>  > SENSEI c0 00
>  > SENSEI c0 00
>  > SENSEI c0 00
>  > status = 80, reply_buffer= c0 0
>  >
>
>
> Can you send a patch for this issue to upstream OpenBIOS?

I've already applied it (r321).