From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LLXbT-0001T7-7C for qemu-devel@nongnu.org; Sat, 10 Jan 2009 01:45:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LLXbR-0001Su-K6 for qemu-devel@nongnu.org; Sat, 10 Jan 2009 01:45:49 -0500 Received: from [199.232.76.173] (port=58178 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLXbR-0001Sq-7c for qemu-devel@nongnu.org; Sat, 10 Jan 2009 01:45:49 -0500 Received: from mail-bw0-f12.google.com ([209.85.218.12]:34351) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LLXbQ-0000yJ-PJ for qemu-devel@nongnu.org; Sat, 10 Jan 2009 01:45:49 -0500 Received: by bwz5 with SMTP id 5so19129504bwz.10 for ; Fri, 09 Jan 2009 22:45:46 -0800 (PST) Message-ID: Date: Sat, 10 Jan 2009 08:45:45 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option In-Reply-To: <4967F942.7040306@eu.citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4967A96B.3020902@eu.citrix.com> <200901091702.22432.paul@codesourcery.com> <4967F942.7040306@eu.citrix.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 1/10/09, Trolle Selander wrote: > Paul Brook wrote: > > > On Friday 09 January 2009 12:45:47 Trolle Selander wrote: > > > > > > > +#ifdef TARGET_SPARC > > > + vga_ram_size += (1024 * 1024); > > > +#endif > > > > > > > > > > This looks pretty bogus. > > > > > > > Possibly. The previous static definition added one meg to the default > VGA_RAM_SIZE if TARGET_SPARC was set, and I merely wanted to retain that > behavior. If someone who is familiar with the SPARC target and knows the > reason for the added meg of ram in the previous code can assure that > this won't be needed with the configurabe ram patch, I'll be happy to > drop that bit. In 24 bit mode, TCX uses a 32 bit framebuffer, 32 bit control plane (selects whether 24 bit mode or 8 bit mode is used for each pixel) and there is still the 8 bit framebuffer, all full screen (1024x768) size. This translates to 4 + 4 + 1 MB. I think the -videoram switch should be disabled for targets with fixed framebuffer hardware in machine description or with: #if !defined(TARGET_SPARC) || defined(TARGET_SPARC64)