From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LMPT0-0005nz-Au for qemu-devel@nongnu.org; Mon, 12 Jan 2009 11:16:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LMPSy-0005k8-5u for qemu-devel@nongnu.org; Mon, 12 Jan 2009 11:16:41 -0500 Received: from [199.232.76.173] (port=58432 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMPSy-0005jn-0k for qemu-devel@nongnu.org; Mon, 12 Jan 2009 11:16:40 -0500 Received: from mail-bw0-f12.google.com ([209.85.218.12]:39728) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LMPSx-00055x-NU for qemu-devel@nongnu.org; Mon, 12 Jan 2009 11:16:39 -0500 Received: by bwz5 with SMTP id 5so21397607bwz.10 for ; Mon, 12 Jan 2009 08:16:38 -0800 (PST) Message-ID: Date: Mon, 12 Jan 2009 18:05:20 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] fix 64 bit issue in slirp In-Reply-To: <20090112150643.GP3267@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090112142807.GN3267@redhat.com> <20090112150643.GP3267@redhat.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 1/12/09, Gleb Natapov wrote: > On Mon, Jan 12, 2009 at 04:54:44PM +0200, Blue Swirl wrote: > > On 1/12/09, Gleb Natapov wrote: > > > > > > Signed-off-by: Gleb Natapov > > > > Great, but did you really fix all pointer accesses, including the port > > number stuff? > > > > All that I found obviously :) And yes the one you are talking about is > fixed. Look at "struct mbuf_ptr" Excellent! The patch passes my tests. I'll apply it unless there are objections. This also means that we can finally get rid of the last warnings.