[Qemu-devel] [PATCH] sparc gdbserver: fix number of regs

[Qemu-devel] [PATCH] sparc gdbserver: fix number of regs

[Tristan Gingold]

Hi,

gdbstubs.c set the number of regs for sparc32 to 73 but gdb expects  
only 72.  As a consequence, gdb
doesn't accept 'g' packets (packets too long).
This patch reduces the number of registers to 72.  This is harmless as  
the 72nd register is not used and
gdb accepts packets that contains less registers.

Tristan.

--- gdbstub.c	(revision 6277)
+++ gdbstub.c	(working copy)
@@ -694,7 +694,7 @@
  #if defined(TARGET_SPARC64) && !defined(TARGET_ABI32)
  #define NUM_CORE_REGS 86
  #else
-#define NUM_CORE_REGS 73
+#define NUM_CORE_REGS 72
  #endif

  #ifdef TARGET_ABI32
@@ -728,7 +728,7 @@
      case 69: GET_REGA(env->npc);
      case 70: GET_REGA(env->fsr);
      case 71: GET_REGA(0); /* csr */
-    case 72: GET_REGA(0);
+    default: GET_REGA(0);
      }
  #else
      if (n < 64) {

Re: [Qemu-devel] [PATCH] sparc gdbserver: fix number of regs

[Blue Swirl]

On 1/13/09, Tristan Gingold <gingold@adacore.com> wrote:
> Hi,
>
>  gdbstubs.c set the number of regs for sparc32 to 73 but gdb expects only
> 72.  As a consequence, gdb
>  doesn't accept 'g' packets (packets too long).
>  This patch reduces the number of registers to 72.  This is harmless as the
> 72nd register is not used and
>  gdb accepts packets that contains less registers.

Excellent! Now my cross-gdb also works. The patch didn't apply but I
fixed it manually and then applied.

Maybe Sparc64 has the same problem?

Re: [Qemu-devel] [PATCH] sparc gdbserver: fix number of regs

[Blue Swirl]

On 1/13/09, Tristan Gingold <gingold@adacore.com> wrote:
> Hi,
>
>  gdbstubs.c set the number of regs for sparc32 to 73 but gdb expects only
> 72.  As a consequence, gdb
>  doesn't accept 'g' packets (packets too long).
>  This patch reduces the number of registers to 72.  This is harmless as the
> 72nd register is not used and
>  gdb accepts packets that contains less registers.

Excellent! Now my cross-gdb also works. The patch didn't apply but I
fixed it manually and then applied.

Maybe Sparc64 has the same problem?

Re: [Qemu-devel] [PATCH] sparc gdbserver: fix number of regs

[Tristan Gingold]

On Jan 13, 2009, at 5:28 PM, Blue Swirl wrote:

> Excellent! Now my cross-gdb also works.

You're welcome.

> Maybe Sparc64 has the same problem?

I haven't built sparc64 but I can check gdbserver.c with gdb code.

Tristan.

Re: [Qemu-devel] [PATCH] sparc gdbserver: fix number of regs

[Blue Swirl]

On 1/13/09, Tristan Gingold <gingold@adacore.com> wrote:
>
>  On Jan 13, 2009, at 5:28 PM, Blue Swirl wrote:
>
>
> > Excellent! Now my cross-gdb also works.
> >
>
>  You're welcome.
>
>
> > Maybe Sparc64 has the same problem?
> >
>
>  I haven't built sparc64 but I can check gdbserver.c with gdb code.

It looks like Sparc64 is correct. The number is defined in gdb sources
in gdb/sparc64-tdep.c (SPARC64_NUM_REGS).