From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNtyy-0006f7-Ft
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:03:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNtyw-0006ah-L3
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:03:51 -0500
Received: from [199.232.76.173] (port=54988 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNtyw-0006aV-H0
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:03:50 -0500
Received: from mail-bw0-f21.google.com ([209.85.218.21]:50521)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LNtyv-0007ZZ-QQ
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:03:50 -0500
Received: by bwz14 with SMTP id 14so5238986bwz.10
	for <qemu-devel@nongnu.org>; Fri, 16 Jan 2009 11:03:48 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4970D6EA.2020700@codemonkey.ws>
References: <E1LNtCH-0000b3-5e@cvs.savannah.gnu.org>
	<4970D2EE.8060206@codemonkey.ws>
	<f43fc5580901161041v52bd5be6u74f00d8a3e1e1e8b@mail.gmail.com>
	<4970D6EA.2020700@codemonkey.ws>
Date: Fri, 16 Jan 2009 21:03:47 +0200
Message-ID: <f43fc5580901161103i58ec9633ob3198d242dd141da@mail.gmail.com>
Subject: Re: [Qemu-devel] [6343] Fix false positive for AIO on OpenBSD
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 1/16/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Blue Swirl wrote:
>
> > On 1/16/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> >
> >
> > > Blue Swirl wrote:
> > >
> > >
> > >
> > > > Revision: 6343
> > > >
> > > >
> > > >
> > >
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6343
> > >
> > >
> > > > Author:   blueswir1
> > > > Date:     2009-01-16 18:13:32 +0000 (Fri, 16 Jan 2009)
> > > >
> > > > Log Message:
> > > > -----------
> > > > Fix false positive for AIO on OpenBSD
> > > >
> > > >
> > > >
> > > >
> > >  If OpenBSD doesn't have sigqueue, we could just replace it with kill.
> I
> > > don't think we need to disable AIO.
> > >
> > >
> >
> > struct sigevent is also missing, is that a problem?
> >
> >
>
>  It's just used for assigning the signal value.  We could have a #ifdef
> HAVE_SIGEVENT and define it if it doesn't exist--or just change the aioinit
> structure to use an int instead of the struct sigevent structure.  It's
> sigevent for glibc compatibility but that's not really important at this
> stage.

Ok. Should kill be used always or just when sigqueue is not available?