qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [6343] Fix false positive for AIO on OpenBSD
Date: Fri, 16 Jan 2009 23:19:43 +0200	[thread overview]
Message-ID: <f43fc5580901161319k1f358cfdn9dccca4ecf4db039@mail.gmail.com> (raw)
In-Reply-To: <4970DB5F.5040608@codemonkey.ws>

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

On 1/16/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Blue Swirl wrote:
>
> > On 1/16/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> >
> >
> > >
> > >  It's just used for assigning the signal value.  We could have a #ifdef
> > > HAVE_SIGEVENT and define it if it doesn't exist--or just change the
> aioinit
> > > structure to use an int instead of the struct sigevent structure.  It's
> > > sigevent for glibc compatibility but that's not really important at this
> > > stage.
> > >
> > >
> >
> > Ok. Should kill be used always or just when sigqueue is not available?
> >
> >
>
>  Since we use it for process instead of thread signaling, I think it's safe
> to always use kill().  I'm not completely sure though, having it conditional
> on sigqueue would certainly be the conservative thing to do.

This version uses just kill. Seems to work on Linux and OpenBSD.

[-- Attachment #2: obsd_aio.diff --]
[-- Type: plain/text, Size: 2054 bytes --]

  reply	other threads:[~2009-01-16 21:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-16 18:13 [Qemu-devel] [6343] Fix false positive for AIO on OpenBSD Blue Swirl
2009-01-16 18:33 ` Anthony Liguori
2009-01-16 18:41   ` Blue Swirl
2009-01-16 18:50     ` Anthony Liguori
2009-01-16 19:03       ` Blue Swirl
2009-01-16 19:09         ` Anthony Liguori
2009-01-16 21:19           ` Blue Swirl [this message]
2009-01-16 21:39             ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580901161319k1f358cfdn9dccca4ecf4db039@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).