From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove unused info_str parameter to pcnet_common_init()
Date: Sat, 17 Jan 2009 22:47:46 +0200 [thread overview]
Message-ID: <f43fc5580901171247uf132b3eof703b48ee2b1df98@mail.gmail.com> (raw)
In-Reply-To: <20090117151459.GA16005@miranda.arrow>
On 1/17/09, Stuart Brady <sdbrady@ntlworld.com> wrote:
> I noticed that pcnet_common_init() takes an unused 'info_str'
> parameter, added in r2142. Since then, we always pass "pcnet"
> to register_savevm() (and never "lance").
>
> Note that r6218 changed vc->info_str to "lance" for sun4m emulation.
>
> On the assumption that it's not needed, this patch removes the
> parameter. If reverting the change in r2142, and registering with
> "lance" would be preferable, I can submit a patch to do so.
>
> Signed-off-by: Stuart Brady <stuart.brady@gmail.com>
Thanks, applied as r6362.
prev parent reply other threads:[~2009-01-17 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 15:14 [Qemu-devel] [PATCH] Remove unused info_str parameter to pcnet_common_init() Stuart Brady
2009-01-17 20:47 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580901171247uf132b3eof703b48ee2b1df98@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).