From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LOI58-00023m-Ma
	for qemu-devel@nongnu.org; Sat, 17 Jan 2009 15:47:50 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LOI57-00022X-Nr
	for qemu-devel@nongnu.org; Sat, 17 Jan 2009 15:47:50 -0500
Received: from [199.232.76.173] (port=55372 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LOI57-00022D-Gf
	for qemu-devel@nongnu.org; Sat, 17 Jan 2009 15:47:49 -0500
Received: from mail-bw0-f21.google.com ([209.85.218.21]:53884)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LOI57-0002h3-3x
	for qemu-devel@nongnu.org; Sat, 17 Jan 2009 15:47:49 -0500
Received: by bwz14 with SMTP id 14so6272935bwz.10
	for <qemu-devel@nongnu.org>; Sat, 17 Jan 2009 12:47:46 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20090117151459.GA16005@miranda.arrow>
References: <20090117151459.GA16005@miranda.arrow>
Date: Sat, 17 Jan 2009 22:47:46 +0200
Message-ID: <f43fc5580901171247uf132b3eof703b48ee2b1df98@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Remove unused info_str parameter to
	pcnet_common_init()
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 1/17/09, Stuart Brady <sdbrady@ntlworld.com> wrote:
> I noticed that pcnet_common_init() takes an unused 'info_str'
>  parameter, added in r2142.  Since then, we always pass "pcnet"
>  to register_savevm() (and never "lance").
>
>  Note that r6218 changed vc->info_str to "lance" for sun4m emulation.
>
>  On the assumption that it's not needed, this patch removes the
>  parameter.  If reverting the change in r2142, and registering with
>  "lance" would be preferable, I can submit a patch to do so.
>
>  Signed-off-by: Stuart Brady <stuart.brady@gmail.com>

Thanks, applied as r6362.