From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add and use #defines for PCI device classes
Date: Sun, 1 Feb 2009 20:12:59 +0200 [thread overview]
Message-ID: <f43fc5580902011012j1a44ed09m49a945dea208dc1f@mail.gmail.com> (raw)
In-Reply-To: <20090201175609.GA14322@miranda.arrow>
On 2/1/09, Stuart Brady <sdbrady@ntlworld.com> wrote:
> This patch adds and uses #defines for PCI device classes and subclases,
> using a new pci_config_set_class() function, similar to the recently
> added pci_config_set_vendor_id() and pci_config_set_device_id().
Nice idea. I think I'll add similar stuff to OpenBIOS too.
> Index: hw/sun4u.c
> ===================================================================
> --- hw/sun4u.c (revision 6490)
> +++ hw/sun4u.c (working copy)
> @@ -373,8 +373,7 @@ pci_ebus_init(PCIBus *bus, int devfn)
> s->config[0x07] = 0x03; // status = medium devsel
> s->config[0x08] = 0x01; // revision
> s->config[0x09] = 0x00; // programming i/f
> - s->config[0x0A] = 0x80; // class_sub = misc bridge
> - s->config[0x0B] = 0x06; // class_base = PCI_bridge
> + pci_config_set_class(d->config, PCI_CLASS_BRIDGE_OTHER);
Borken, s != d.
next prev parent reply other threads:[~2009-02-01 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 17:56 [Qemu-devel] [PATCH] Add and use #defines for PCI device classes Stuart Brady
2009-02-01 18:12 ` Blue Swirl [this message]
2009-02-01 18:13 ` Stuart Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580902011012j1a44ed09m49a945dea208dc1f@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).