From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LUlr2-0005CM-8v
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 12:48:04 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LUlqy-0005A7-Af
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 12:48:03 -0500
Received: from [199.232.76.173] (port=53033 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LUlqy-0005A0-3I
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 12:48:00 -0500
Received: from mail-fx0-f20.google.com ([209.85.220.20]:54012)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LUlqx-0003OT-KX
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 12:47:59 -0500
Received: by fxm13 with SMTP id 13so3340864fxm.10
	for <qemu-devel@nongnu.org>; Wed, 04 Feb 2009 09:47:57 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20090204133924.976199377@localhost.localdomain>
References: <20090204133303.113145633@localhost.localdomain>
	<20090204133924.976199377@localhost.localdomain>
Date: Wed, 4 Feb 2009 19:47:57 +0200
Message-ID: <f43fc5580902040947g4d530177t576843825485adb4@mail.gmail.com>
Subject: Re: [Qemu-devel] [patch 18/18] qemu: PCI device, disk and host
	network hot-add / hot-remove
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>

On 2/4/09, Marcelo Tosatti <mtosatti@redhat.com> wrote:
> Add monitor command to hot-add PCI devices (nic and storage).

>  +#define PCI_BASE_CLASS_STORAGE          0x01
>  +#define PCI_BASE_CLASS_NETWORK          0x02

These belong to hw/pci.h.

>  +    const char *valid_param_list[] = { "tap", "user", "socket"
>  +#ifdef CONFIG_VDE
>  +                                       ,"vde"
>  +#endif

"user" should be conditional to CONFIG_SLIRP.