[Qemu-devel] [PATCH] Fix SIGSEGV crash in slirp networking code

[Qemu-devel] [PATCH] Fix SIGSEGV crash in slirp networking code

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]


Hello,

this patch fixes a bug which was introduced in r6288.
Please apply it to Qemu trunk.

See this discussion for details:

http://lists.gnu.org/archive/cgi-bin/namazu.cgi?query=Regression+in+networking+code+(SIGSEGV)&submit=Search&idxname=qemu-devel

Regards
Stefan Weil




[-- Attachment #2: slirp.patch --]
[-- Type: text/x-diff, Size: 615 bytes --]

Fix SIGSEGV crash in networking code (bug was introduced in r6288).
Thanks to Gleb Natapov for finding this fix.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Index: trunk/slirp/ip_input.c
===================================================================
--- trunk.orig/slirp/ip_input.c	2009-02-05 22:16:34.000000000 +0100
+++ trunk/slirp/ip_input.c	2009-02-05 22:17:02.000000000 +0100
@@ -392,8 +392,7 @@
 	 * into the new buffer.
 	 */
 	if (m->m_flags & M_EXT) {
-	  int delta;
-	  delta = (char *)ip - m->m_dat;
+	  int delta = (char *)q - m->m_dat;
 	  q = (struct ipasfrag *)(m->m_ext + delta);
 	}
 

Re: [Qemu-devel] [PATCH] Fix SIGSEGV crash in slirp networking code

[Blue Swirl]

On 2/6/09, Stefan Weil <weil@mail.berlios.de> wrote:
>
>  Hello,
>
>  this patch fixes a bug which was introduced in r6288.
>  Please apply it to Qemu trunk.
>
>  See this discussion for details:
>
>  http://lists.gnu.org/archive/cgi-bin/namazu.cgi?query=Regression+in+networking+code+(SIGSEGV)&submit=Search&idxname=qemu-devel

Thanks, applied.