[Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Blue Swirl]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi,

This set of patches adds basic support for Mac99 Qemu machine,
provided by ppc_chrp.c. I've used the device tree of iMac DV ('99) as
reference:
http://penguinppc.org/historical/dev-trees-html/imac-dv-99.html

The patches changes the machine to use OpenBIOS instead of OHW and
otherwise breaks OHW assumptions. On OpenBIOS side there are still
some missing bits.

Comments welcome.

[-- Attachment #2: o_chrp_support.diff --]
[-- Type: plain/text, Size: 7344 bytes --]

[-- Attachment #3: q_1_chrp_use_openbios.diff --]
[-- Type: plain/text, Size: 2311 bytes --]

[-- Attachment #4: q_2_chrp_use_mac_nvram.diff --]
[-- Type: plain/text, Size: 1857 bytes --]

[-- Attachment #5: q_3_fix_unin_config.diff --]
[-- Type: plain/text, Size: 1138 bytes --]

[-- Attachment #6: q_4_chrp_use_pmac_ide.diff --]
[-- Type: plain/text, Size: 1099 bytes --]

[-- Attachment #7: q_5_load_32bit_bios.diff --]
[-- Type: plain/text, Size: 1855 bytes --]

Re: [Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Aurelien Jarno]

On Sat, Feb 07, 2009 at 01:38:58PM +0200, Blue Swirl wrote:
> Hi,
Hi!

> This set of patches adds basic support for Mac99 Qemu machine,

As you ask the question in the subject, this machine is a NewWorld
machine, and not a CHRP one. I think we don't really want to provide a
CHRP emulated machine, so the best is probably to rename ppc_chrp.c into
ppc_newworld.c.

> provided by ppc_chrp.c. I've used the device tree of iMac DV ('99) as
> reference:
> http://penguinppc.org/historical/dev-trees-html/imac-dv-99.html
> 
> The patches changes the machine to use OpenBIOS instead of OHW and
> otherwise breaks OHW assumptions. On OpenBIOS side there are still
> some missing bits.
> 
> Comments welcome.

Great work.

I gave a quick look at the patches, they looks fine. However I still
experience some problem with the PowerMac IDE emulation, especially with
recent kernels, so until it is fixed (Laurent is working on that) I 
think we should keep the CMD646 as a default.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [OpenBIOS] [Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Blue Swirl]

On 2/7/09, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Sat, Feb 07, 2009 at 01:38:58PM +0200, Blue Swirl wrote:
>  > Hi,
>
> Hi!
>
>  > This set of patches adds basic support for Mac99 Qemu machine,
>
>
> As you ask the question in the subject, this machine is a NewWorld
>  machine, and not a CHRP one. I think we don't really want to provide a
>  CHRP emulated machine, so the best is probably to rename ppc_chrp.c into
>  ppc_newworld.c.

True. I think RS6000 series were closest to CHRP, not iMac.

The rename does not affect OHW status, so it could be done immediately.

>  > provided by ppc_chrp.c. I've used the device tree of iMac DV ('99) as
>  > reference:
>  > http://penguinppc.org/historical/dev-trees-html/imac-dv-99.html
>  >
>  > The patches changes the machine to use OpenBIOS instead of OHW and
>  > otherwise breaks OHW assumptions. On OpenBIOS side there are still
>  > some missing bits.
>  >
>  > Comments welcome.
>
>
> Great work.
>
>  I gave a quick look at the patches, they looks fine. However I still
>  experience some problem with the PowerMac IDE emulation, especially with
>  recent kernels, so until it is fixed (Laurent is working on that) I
>  think we should keep the CMD646 as a default.

OK¸ I'll change that part and send new patches.

Re: [OpenBIOS] [Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Blue Swirl]

[-- Attachment #1: Type: text/plain, Size: 1990 bytes --]

On 2/7/09, Blue Swirl <blauwirbel@gmail.com> wrote:
> On 2/7/09, Aurelien Jarno <aurelien@aurel32.net> wrote:
>  > On Sat, Feb 07, 2009 at 01:38:58PM +0200, Blue Swirl wrote:
>  >  > Hi,
>  >
>  > Hi!
>  >
>  >  > This set of patches adds basic support for Mac99 Qemu machine,
>  >
>  >
>  > As you ask the question in the subject, this machine is a NewWorld
>  >  machine, and not a CHRP one. I think we don't really want to provide a
>  >  CHRP emulated machine, so the best is probably to rename ppc_chrp.c into
>  >  ppc_newworld.c.
>
>
> True. I think RS6000 series were closest to CHRP, not iMac.
>
>  The rename does not affect OHW status, so it could be done immediately.
>
>
>  >  > provided by ppc_chrp.c. I've used the device tree of iMac DV ('99) as
>  >  > reference:
>  >  > http://penguinppc.org/historical/dev-trees-html/imac-dv-99.html
>  >  >
>  >  > The patches changes the machine to use OpenBIOS instead of OHW and
>  >  > otherwise breaks OHW assumptions. On OpenBIOS side there are still
>  >  > some missing bits.
>  >  >
>  >  > Comments welcome.
>  >
>  >
>  > Great work.
>  >
>  >  I gave a quick look at the patches, they looks fine. However I still
>  >  experience some problem with the PowerMac IDE emulation, especially with
>  >  recent kernels, so until it is fixed (Laurent is working on that) I
>  >  think we should keep the CMD646 as a default.
>
>
> OK¸ I'll change that part and send new patches.

This new set of patches perform the rename (to be replaced with SVN
operation). CMD646 is used instead of pmac ide.

Debian 4.0 R6 cd image boots, installer starts but keyboard does not
work (probably because OpenBIOS doesn't advertise OpenPic).

The 6th patch is not wanted, it just switches CMD646 back to pmac, but
it's there if someone wants to play.

Should these be committed or do we want to wait for more OpenBIOS
updates? At least the OpenBIOS patch, patch #0 and patch #5 are
harmless.

[-- Attachment #2: o_newworld_support.diff --]
[-- Type: plain/text, Size: 7344 bytes --]

[-- Attachment #3: q_0_rename_chrp_newworld.diff --]
[-- Type: plain/text, Size: 27457 bytes --]

[-- Attachment #4: q_1_newworld_use_openbios.diff --]
[-- Type: plain/text, Size: 2323 bytes --]

[-- Attachment #5: q_2_newworld_use_mac_nvram.diff --]
[-- Type: plain/text, Size: 1869 bytes --]

[-- Attachment #6: q_3_fix_unin_config.diff --]
[-- Type: plain/text, Size: 1138 bytes --]

[-- Attachment #7: q_4b_newworld_use_cmd646.diff --]
[-- Type: plain/text, Size: 1256 bytes --]

[-- Attachment #8: q_5_load_32bit_bios.diff --]
[-- Type: plain/text, Size: 1867 bytes --]

[-- Attachment #9: q_6_newworld_use_pmac_ide.diff --]
[-- Type: plain/text, Size: 1267 bytes --]

Re: [OpenBIOS] [Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Natalia Portillo]

Should't we stay emulating the machines as they were?

If we are emulating a Macintosh, it should have whatever controllers  
the Macintosh had.
If they does not work, specially for booting a third party system,  
they should be repared, and not be substitued for another one not used  
on that machine.

Tried to boot any Mac OS?

El 07/02/2009, a las 21:05, Blue Swirl escribió:

> On 2/7/09, Blue Swirl <blauwirbel@gmail.com> wrote:
>> On 2/7/09, Aurelien Jarno <aurelien@aurel32.net> wrote:
>>> On Sat, Feb 07, 2009 at 01:38:58PM +0200, Blue Swirl wrote:
>>>> Hi,
>>>
>>> Hi!
>>>
>>>> This set of patches adds basic support for Mac99 Qemu machine,
>>>
>>>
>>> As you ask the question in the subject, this machine is a NewWorld
>>> machine, and not a CHRP one. I think we don't really want to  
>>> provide a
>>> CHRP emulated machine, so the best is probably to rename  
>>> ppc_chrp.c into
>>> ppc_newworld.c.
>>
>>
>> True. I think RS6000 series were closest to CHRP, not iMac.
>>
>> The rename does not affect OHW status, so it could be done  
>> immediately.
>>
>>
>>>> provided by ppc_chrp.c. I've used the device tree of iMac DV  
>>>> ('99) as
>>>> reference:
>>>> http://penguinppc.org/historical/dev-trees-html/imac-dv-99.html
>>>>
>>>> The patches changes the machine to use OpenBIOS instead of OHW and
>>>> otherwise breaks OHW assumptions. On OpenBIOS side there are still
>>>> some missing bits.
>>>>
>>>> Comments welcome.
>>>
>>>
>>> Great work.
>>>
>>> I gave a quick look at the patches, they looks fine. However I still
>>> experience some problem with the PowerMac IDE emulation,  
>>> especially with
>>> recent kernels, so until it is fixed (Laurent is working on that) I
>>> think we should keep the CMD646 as a default.
>>
>>
>> OK¸ I'll change that part and send new patches.
>
> This new set of patches perform the rename (to be replaced with SVN
> operation). CMD646 is used instead of pmac ide.
>
> Debian 4.0 R6 cd image boots, installer starts but keyboard does not
> work (probably because OpenBIOS doesn't advertise OpenPic).
>
> The 6th patch is not wanted, it just switches CMD646 back to pmac, but
> it's there if someone wants to play.
>
> Should these be committed or do we want to wait for more OpenBIOS
> updates? At least the OpenBIOS patch, patch #0 and patch #5 are
> harmless.
> < 
> o_newworld_support 
> .diff 
> > 
> < 
> q_0_rename_chrp_newworld 
> .diff 
> > 
> < 
> q_1_newworld_use_openbios 
> .diff 
> > 
> < 
> q_2_newworld_use_mac_nvram 
> .diff 
> > 
> < 
> q_3_fix_unin_config 
> .diff 
> > 
> < 
> q_4b_newworld_use_cmd646 
> .diff><q_5_load_32bit_bios.diff><q_6_newworld_use_pmac_ide.diff>

Re: [OpenBIOS] [Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Blue Swirl]

On 2/8/09, Natalia Portillo <claunia@claunia.com> wrote:
> Should't we stay emulating the machines as they were?
>
>  If we are emulating a Macintosh, it should have whatever controllers the
> Macintosh had.
>  If they does not work, specially for booting a third party system, they
> should be repared, and not be substitued for another one not used on that
> machine.

This is just temporary until the pmac ide is fixed. Isn't it also
possible that even with the real machine a user may have added a
CMD646 PCI card and connected all drives to it?

>  Tried to boot any Mac OS?

No, are there free and preferably open source boot CD images somewhere?

Re: [OpenBIOS] [Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Stuart Brady]

On Sun, Feb 08, 2009 at 09:52:42AM +0200, Blue Swirl wrote:
> On 2/8/09, Natalia Portillo <claunia@claunia.com> wrote:
> 
> >  Tried to boot any Mac OS?
> 
> No, are there free and preferably open source boot CD images somewhere?

Would Darwin be of any use?

http://www.opensource.apple.com/darwinsource/images/darwinppc-801.cdr.gz

(Shame Apple force you to register to download their images...)
-- 
Stuart Brady

Re: [OpenBIOS] [Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Aurelien Jarno]

On Sat, Feb 07, 2009 at 11:05:52PM +0200, Blue Swirl wrote:
> On 2/7/09, Blue Swirl <blauwirbel@gmail.com> wrote:
> > On 2/7/09, Aurelien Jarno <aurelien@aurel32.net> wrote:
> >  > On Sat, Feb 07, 2009 at 01:38:58PM +0200, Blue Swirl wrote:
> >  >  > Hi,
> >  >
> >  > Hi!
> >  >
> >  >  > This set of patches adds basic support for Mac99 Qemu machine,
> >  >
> >  >
> >  > As you ask the question in the subject, this machine is a NewWorld
> >  >  machine, and not a CHRP one. I think we don't really want to provide a
> >  >  CHRP emulated machine, so the best is probably to rename ppc_chrp.c into
> >  >  ppc_newworld.c.
> >
> >
> > True. I think RS6000 series were closest to CHRP, not iMac.
> >
> >  The rename does not affect OHW status, so it could be done immediately.
> >
> >
> >  >  > provided by ppc_chrp.c. I've used the device tree of iMac DV ('99) as
> >  >  > reference:
> >  >  > http://penguinppc.org/historical/dev-trees-html/imac-dv-99.html
> >  >  >
> >  >  > The patches changes the machine to use OpenBIOS instead of OHW and
> >  >  > otherwise breaks OHW assumptions. On OpenBIOS side there are still
> >  >  > some missing bits.
> >  >  >
> >  >  > Comments welcome.
> >  >
> >  >
> >  > Great work.
> >  >
> >  >  I gave a quick look at the patches, they looks fine. However I still
> >  >  experience some problem with the PowerMac IDE emulation, especially with
> >  >  recent kernels, so until it is fixed (Laurent is working on that) I
> >  >  think we should keep the CMD646 as a default.
> >
> >
> > OK¸ I'll change that part and send new patches.
> 
> This new set of patches perform the rename (to be replaced with SVN
> operation). CMD646 is used instead of pmac ide.
> 
> Debian 4.0 R6 cd image boots, installer starts but keyboard does not
> work (probably because OpenBIOS doesn't advertise OpenPic).

That may be the problem. Alternatively, note that NewWorld machine are
not suppose to support ADB bus, so maybe the kernel is disabling that
part. We should switch the keyboard and the mouse to USB as on real
machines. We already have the code on the QEMU side, so it should be
easy. On the OpenBIOS side the code to support an USB keyboard is
probably more complicated.

> The 6th patch is not wanted, it just switches CMD646 back to pmac, but
> it's there if someone wants to play.
> 
> Should these be committed or do we want to wait for more OpenBIOS
> updates? At least the OpenBIOS patch, patch #0 and patch #5 are
> harmless.

For QEMU, I think there is no problem with that. For OpenBIOS, I think
as long as the patches don't break the OldWorld platform, they can be
applied.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [OpenBIOS] [Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Christian Brunschen]

On 8 Feb 2009, at 14:15, Aurelien Jarno wrote:


> Alternatively, note that NewWorld machine are
> not suppose to support ADB bus, so maybe the kernel is disabling that
> part.

I'm not entirely certain about that - I seem to recall that at least  
some PowerBook G4s had their keyboard and trackpad connected through  
an internal ADB connection. For instance, if you look at <http://tstotts.net/linux/gentoopb.html 
 >, it describes a particular _Aluminium_ PowerBook G4 as having a  
back-lit ADB keyboard.

// Christian Brunschen

Re: [OpenBIOS] [Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Blue Swirl]

On 2/8/09, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Sat, Feb 07, 2009 at 11:05:52PM +0200, Blue Swirl wrote:
>  > On 2/7/09, Blue Swirl <blauwirbel@gmail.com> wrote:
>  > > On 2/7/09, Aurelien Jarno <aurelien@aurel32.net> wrote:
>  > >  > On Sat, Feb 07, 2009 at 01:38:58PM +0200, Blue Swirl wrote:
>  > >  >  > Hi,
>  > >  >
>  > >  > Hi!
>  > >  >
>  > >  >  > This set of patches adds basic support for Mac99 Qemu machine,
>  > >  >
>  > >  >
>  > >  > As you ask the question in the subject, this machine is a NewWorld
>  > >  >  machine, and not a CHRP one. I think we don't really want to provide a
>  > >  >  CHRP emulated machine, so the best is probably to rename ppc_chrp.c into
>  > >  >  ppc_newworld.c.
>  > >
>  > >
>  > > True. I think RS6000 series were closest to CHRP, not iMac.
>  > >
>  > >  The rename does not affect OHW status, so it could be done immediately.
>  > >
>  > >
>  > >  >  > provided by ppc_chrp.c. I've used the device tree of iMac DV ('99) as
>  > >  >  > reference:
>  > >  >  > http://penguinppc.org/historical/dev-trees-html/imac-dv-99.html
>  > >  >  >
>  > >  >  > The patches changes the machine to use OpenBIOS instead of OHW and
>  > >  >  > otherwise breaks OHW assumptions. On OpenBIOS side there are still
>  > >  >  > some missing bits.
>  > >  >  >
>  > >  >  > Comments welcome.
>  > >  >
>  > >  >
>  > >  > Great work.
>  > >  >
>  > >  >  I gave a quick look at the patches, they looks fine. However I still
>  > >  >  experience some problem with the PowerMac IDE emulation, especially with
>  > >  >  recent kernels, so until it is fixed (Laurent is working on that) I
>  > >  >  think we should keep the CMD646 as a default.
>  > >
>  > >
>  > > OK¸ I'll change that part and send new patches.
>  >
>  > This new set of patches perform the rename (to be replaced with SVN
>  > operation). CMD646 is used instead of pmac ide.
>  >
>  > Debian 4.0 R6 cd image boots, installer starts but keyboard does not
>  > work (probably because OpenBIOS doesn't advertise OpenPic).
>
>
> That may be the problem. Alternatively, note that NewWorld machine are
>  not suppose to support ADB bus, so maybe the kernel is disabling that
>  part. We should switch the keyboard and the mouse to USB as on real
>  machines. We already have the code on the QEMU side, so it should be
>  easy. On the OpenBIOS side the code to support an USB keyboard is
>  probably more complicated.

Well, I just found out that even without any USB support in OpenBIOS,
Linux finds the OHCI device and then the keyboard and mouse connected
to it, so keyboard works using the same Debian image.