From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LXKt8-0001FW-IT for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:36:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LXKt6-0001DI-Sk for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:36:50 -0500 Received: from [199.232.76.173] (port=51856 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXKt6-0001Cs-Fs for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:36:48 -0500 Received: from mail-fx0-f20.google.com ([209.85.220.20]:50823) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LXKt5-0002vA-TB for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:36:48 -0500 Received: by fxm13 with SMTP id 13so1203529fxm.10 for ; Wed, 11 Feb 2009 11:36:44 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <49932089.2050708@codemonkey.ws> References: <87iqnh6kyv.fsf@pike.pond.sub.org> <49932089.2050708@codemonkey.ws> Date: Wed, 11 Feb 2009 21:36:44 +0200 Message-ID: Subject: Re: [Qemu-devel] [RFC] Machine description as data From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 2/11/09, Anthony Liguori wrote: > I think your approach is pretty sound. A few observations: > > 1) obviously need to eliminate the code duplication > > 2) the new code should fit with the rest of QEMU stylistically > > 3) I'd prefer incremental vs. perfect so let's try to do as much > refactoring that will be required before actually going the full 9 yards and > implementing the config file. > > 4) we don't have to solve all problems all at once as long as we don't > regress existing features I'd still want to see if a FDT based solution is possible before taking a homebrew version.