From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LXeuz-0005PE-7q
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 12:00:05 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LXeux-0005OQ-DN
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 12:00:04 -0500
Received: from [199.232.76.173] (port=39634 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LXeux-0005OL-2n
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 12:00:03 -0500
Received: from mail-bw0-f157.google.com ([209.85.218.157]:54748)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LXeuw-0006vL-BJ
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 12:00:02 -0500
Received: by bwz1 with SMTP id 1so1233143bwz.10
	for <qemu-devel@nongnu.org>; Thu, 12 Feb 2009 09:00:00 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20090212163710.GD13234@redhat.com>
References: <20090212081025.29410.94176.stgit@dhcp-1-237.tlv.redhat.com>
	<f43fc5580902120753n1455e531gc510588428fe65dc@mail.gmail.com>
	<20090212163710.GD13234@redhat.com>
Date: Thu, 12 Feb 2009 18:59:59 +0200
Message-ID: <f43fc5580902120859h6dc2054cj6d09d55160a83583@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Allow additions of ACPI tables from command
	line
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 2/12/09, Gleb Natapov <gleb@redhat.com> wrote:
> On Thu, Feb 12, 2009 at 05:53:24PM +0200, Blue Swirl wrote:
>  > On 2/12/09, Gleb Natapov <gleb@redhat.com> wrote:
>  > > This is needed to dynamically add SLIC tables with Windows
>  > >  activation keys.
>  >
>  > >  +--- a/bios/rombios32.c
>  > >  ++++ b/bios/rombios32.c
>  > >  +@@ -455,6 +455,8 @@ unsigned long bios_table_end_addr;
>  > >  + #define QEMU_CFG_SIGNATURE  0x00
>  > >  + #define QEMU_CFG_ID         0x01
>  > >  + #define QEMU_CFG_UUID       0x02
>  > >  ++#define FW_CFG_ARCH_LOCAL     0x8000
>  > >  ++#define FW_CFG_ACPI_TABLES  (FW_CFG_ARCH_LOCAL + 0)
>  >
>  > Why don't you just copy the file hw/fw_cfg.h as is? It's designed to
>  > be included even from assembler files.
>  >
>
> Bochs is another project. We can copy the file once but than we will have to
>  sync it each time it changes in qemu anyway.

But we have to sync anyway even if the defines are directly used in
Bochs files. With fw_cfg.h in Bochs, the sync would be 'cp', instead
of manual editing with copy/paste.

OpenBIOS uses verbatim copies of fw_cfg.h and firmware_abi.h.