From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Cc: kvm-ppc@vger.kernel.org, Liu Yu <yu.liu@freescale.com>,
hollisb@us.ibm.com, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support
Date: Tue, 17 Feb 2009 17:09:04 +0200 [thread overview]
Message-ID: <f43fc5580902170709n3ba3f5f6o71a46769d1449c00@mail.gmail.com> (raw)
In-Reply-To: <1234864778-19099-3-git-send-email-yu.liu@freescale.com>
On 2/17/09, Liu Yu <yu.liu@freescale.com> wrote:
> This patch add the emulation of freescale's pci controller for E500 platform.
>
> Signed-off-by: Liu Yu <yu.liu@freescale.com>
A reset function (registered with qemu_register_reset) would be nice.
> + * Copyright (C) 2009 Freescale Semiconductor, Inc. All rights reserved.
"All rights reserved" conflicts with GPL.
> + d->config[0x00] = 0x57; // vendor_id
> + d->config[0x01] = 0x19;
> + d->config[0x02] = 0x30; // device_id
> + d->config[0x03] = 0x00;
Please use pci_config_set_vendor_id and pci_config_set_device_id
functions and add the ID #defines to hw/pci.h.
> + d->config[0x0a] = 0x20; // class_sub = other bridge type
> + d->config[0x0b] = 0x0B; // class_base = PCI_bridge
I'd think these should be 0x06 (PCI_BASE_CLASS_BRIDGE) and 0x04
(PCI_CLASS_BRIDGE_PCI). Are these correct?
next prev parent reply other threads:[~2009-02-17 15:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 9:59 [Qemu-devel] powerpc/kvm: Add MPC8544DS board support Liu Yu
2009-02-17 9:59 ` [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform Liu Yu
2009-02-17 9:59 ` [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support Liu Yu
2009-02-17 9:59 ` [Qemu-devel] [PATCH 3/5] kvm/powerpc: Add irq support for E500 core Liu Yu
2009-02-17 9:59 ` [Qemu-devel] [PATCH 4/5] kvm/powerpc: Add MPC8544DS board support Liu Yu
2009-02-17 9:59 ` [Qemu-devel] [PATCH 5/5] kvm/powerpc: flat device tree files for MPC8544DS Liu Yu
2009-02-17 15:28 ` [Qemu-devel] [PATCH 4/5] kvm/powerpc: Add MPC8544DS board support Blue Swirl
2009-02-18 7:01 ` Liu Yu-B13201
2009-02-17 15:09 ` Blue Swirl [this message]
2009-02-17 16:08 ` [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support M. Warner Losh
2009-02-17 16:23 ` M. Warner Losh
2009-02-17 17:41 ` Jamie Lokier
2009-02-18 6:04 ` Liu Yu-B13201
2009-02-17 14:55 ` [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform Blue Swirl
2009-02-18 7:17 ` Liu Yu-B13201
2009-02-19 22:41 ` Aurelien Jarno
2009-02-20 17:20 ` Blue Swirl
2009-02-19 23:09 ` Paulev
-- strict thread matches above, loose matches on Subject: below --
2009-02-26 10:35 [Qemu-devel] [PATCH v4 0/5] powerpc/kvm: Add MPC8544DS board support Liu Yu
2009-02-26 10:35 ` [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform Liu Yu
2009-02-26 10:35 ` [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support Liu Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580902170709n3ba3f5f6o71a46769d1449c00@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=aurelien@aurel32.net \
--cc=hollisb@us.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=yu.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).