From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LZRZg-00057k-EN
	for qemu-devel@nongnu.org; Tue, 17 Feb 2009 10:09:28 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LZRZd-000519-Jw
	for qemu-devel@nongnu.org; Tue, 17 Feb 2009 10:09:27 -0500
Received: from [199.232.76.173] (port=34081 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LZRZd-00050x-AI
	for qemu-devel@nongnu.org; Tue, 17 Feb 2009 10:09:25 -0500
Received: from fk-out-0910.google.com ([209.85.128.186]:37955)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LZRZc-0007q6-V8
	for qemu-devel@nongnu.org; Tue, 17 Feb 2009 10:09:25 -0500
Received: by fk-out-0910.google.com with SMTP id z23so1445272fkz.2
	for <qemu-devel@nongnu.org>; Tue, 17 Feb 2009 07:09:23 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1234864778-19099-3-git-send-email-yu.liu@freescale.com>
References: <1234864778-19099-1-git-send-email-yu.liu@freescale.com>
	<1234864778-19099-2-git-send-email-yu.liu@freescale.com>
	<1234864778-19099-3-git-send-email-yu.liu@freescale.com>
Date: Tue, 17 Feb 2009 17:09:04 +0200
Message-ID: <f43fc5580902170709n3ba3f5f6o71a46769d1449c00@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci
	controller's support
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: kvm-ppc@vger.kernel.org, Liu Yu <yu.liu@freescale.com>, hollisb@us.ibm.com, aurelien@aurel32.net

On 2/17/09, Liu Yu <yu.liu@freescale.com> wrote:
> This patch add the emulation of freescale's pci controller for E500 platform.
>
>  Signed-off-by: Liu Yu <yu.liu@freescale.com>

A reset function (registered with qemu_register_reset) would be nice.

>  + * Copyright (C) 2009 Freescale Semiconductor, Inc. All rights reserved.

"All rights reserved" conflicts with GPL.

>  +    d->config[0x00] = 0x57; // vendor_id
>  +    d->config[0x01] = 0x19;
>  +    d->config[0x02] = 0x30; // device_id
>  +    d->config[0x03] = 0x00;

Please use pci_config_set_vendor_id and pci_config_set_device_id
functions and add the ID #defines to hw/pci.h.

>  +    d->config[0x0a] = 0x20; // class_sub = other bridge type
>  +    d->config[0x0b] = 0x0B; // class_base = PCI_bridge

I'd think these should be 0x06 (PCI_BASE_CLASS_BRIDGE) and 0x04
(PCI_CLASS_BRIDGE_PCI). Are these correct?