From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LaZ3F-0001jH-Hw
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 12:20:37 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LaZ3E-0001iN-0a
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 12:20:37 -0500
Received: from [199.232.76.173] (port=39280 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LaZ3D-0001iI-Sp
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 12:20:35 -0500
Received: from mail-bw0-f157.google.com ([209.85.218.157]:60310)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LaZ3D-0004ca-L8
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 12:20:35 -0500
Received: by bwz1 with SMTP id 1so2748004bwz.10
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2009 09:20:33 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20090219224153.GE27283@hall.aurel32.net>
References: <1234864778-19099-1-git-send-email-yu.liu@freescale.com>
	<1234864778-19099-2-git-send-email-yu.liu@freescale.com>
	<f43fc5580902170655w4dadb1aem31bf8d5d6742d50e@mail.gmail.com>
	<20090219224153.GE27283@hall.aurel32.net>
Date: Fri, 20 Feb 2009 19:20:33 +0200
Message-ID: <f43fc5580902200920o3b95318dqad4c5f6257d05c98@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500
	platform.
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: hollisb@us.ibm.com, Liu Yu <yu.liu@freescale.com>, qemu-devel@nongnu.org, kvm-ppc@vger.kernel.org

On 2/20/09, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Tue, Feb 17, 2009 at 04:55:51PM +0200, Blue Swirl wrote:
>  > On 2/17/09, Liu Yu <yu.liu@freescale.com> wrote:
>  > > MPIC and OpenPIC have very similar design.
>  > >  So a lot of code can be reused.
>  > >
>  > >  Modification mainly include:
>  > >  1. keep struct openpic_t to the maximum size of both MPIC and OpenPIC.
>  > >  2. endianess swap.
>  > >    MPIC has the same endianess as target, so no need to swap for MPIC.
>  >
>  > I don't think this is correct, the host can still be different endian
>  > from target.
>  >
>
>
> I do not agree. As long as we don't manipulate host memory, the host
>  endianess has nothing to do. The values are simply passed by value, they
>  don't need to be swapped.

Sorry, I stand corrected.