Re: [Qemu-devel] [PATCH] Enable support for PPC64 on qemu target v2

[Blue Swirl <blauwirbel@gmail.com>]

On 2/27/09, Alexander Graf <alex@csgraf.de> wrote:
> This patch enables OpenBIOS to initialize on PPC64, enabling support for
> -cpu 970fx.
> It gets up to the boot prompt and works rather good so far, though I haven't
> been able to run a kernel yet.
>
> For more recent PowerPC CPUs the PTE layout has changed, so we need to take
> that into account and create PTEs according to the new layout and at the new
> physical positions.
>
> v2 takes Laurent's comments into account
>
> Signed-off-by: Alexander Graf <alex@csgraf.de>

Great work. Just a minor nit:

+	vsid = (ea>>28) + SEGR_BASE;

Please add spaces around ">>".

I wonder if is_ppc64() is correct for all known CPUs. Alternatively
the CPU init function could set a global is_ppc64 flag, or call  the
MMU initialize function.

In dsi_exception the mask could be initialized just once and in other
cases a static value could be used for speed. The speed of OpenBIOS is
of course not very critical.