From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ld8wY-0004t5-QE for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:04:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ld8wW-0004qc-Nu for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:04:22 -0500 Received: from [199.232.76.173] (port=37662 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ld8wV-0004qS-8V for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:04:19 -0500 Received: from mail-fx0-f175.google.com ([209.85.220.175]:61352) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ld8wU-0007mC-Ic for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:04:18 -0500 Received: by fxm23 with SMTP id 23so1124375fxm.34 for ; Fri, 27 Feb 2009 12:04:17 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <0A1FE637C2C7E148B9573BB60CC630E5110C79@zch01exm26.fsl.freescale.net> References: <1235644545-20816-1-git-send-email-yu.liu@freescale.com> <1235644545-20816-2-git-send-email-yu.liu@freescale.com> <0A1FE637C2C7E148B9573BB60CC630E5110C79@zch01exm26.fsl.freescale.net> Date: Fri, 27 Feb 2009 22:04:17 +0200 Message-ID: From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yu-B13201 Cc: kvm-ppc@vger.kernel.org, hollisb@us.ibm.com, qemu-devel@nongnu.org, aurelien@aurel32.net On 2/27/09, Liu Yu-B13201 wrote: > > > > -----Original Message----- > > From: Blue Swirl [mailto:blauwirbel@gmail.com] > > Sent: Friday, February 27, 2009 2:47 AM > > To: Liu Yu-B13201 > > Cc: qemu-devel@nongnu.org; aurelien@aurel32.net; > > hollisb@us.ibm.com; kvm-ppc@vger.kernel.org > > Subject: Re: [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform. > > > > On 2/26/09, Liu Yu wrote: > > > MPIC and OpenPIC have very similar design. > > > So a lot of code can be reused. > > > > > > Modification mainly include: > > > 1. keep struct openpic_t to the maximum size of both MPIC > > and OpenPIC. > > > 2. endianess swap. > > > MPIC has the same endianess as target, so no need to > > swap for MPIC. > > > 3. using different init functions and function pointers > > for reset and irq raise. > > > > > > Haven't test OpenPIC. > > > > > > Signed-off-by: Liu Yu > > > > > + struct { > > > + CPUReadMemoryFunc **read; > > > + CPUWriteMemoryFunc **write; > > > + target_phys_addr_t start_addr; > > > + ram_addr_t size; > > > + } list[] = { > > > + {mpic_glb_read, mpic_glb_write, > > MPIC_GLB_REG_START, MPIC_GLB_REG_SIZE}, > > > + {mpic_tmr_read, mpic_tmr_write, > > MPIC_TMR_REG_START, MPIC_TMR_REG_SIZE}, > > > + {mpic_ext_read, mpic_ext_write, > > MPIC_EXT_REG_START, MPIC_EXT_REG_SIZE}, > > > + {mpic_int_read, mpic_int_write, > > MPIC_INT_REG_START, MPIC_INT_REG_SIZE}, > > > + {mpic_msg_read, mpic_msg_write, > > MPIC_MSG_REG_START, MPIC_MSG_REG_SIZE}, > > > + {mpic_msi_read, mpic_msi_write, > > MPIC_MSI_REG_START, MPIC_MSI_REG_SIZE}, > > > + {mpic_cpu_read, mpic_cpu_write, > > MPIC_CPU_REG_START, MPIC_CPU_REG_SIZE}, > > > + }; > > > > "static const" ? > > > > > Why static? It's allocated on stack and will be free when function return. True, but it will be constructed for every call. But as this function will be called only once, it does not matter too much.