From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ld92k-0001Ai-3k
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:10:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ld92i-00019G-HP
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:10:45 -0500
Received: from [199.232.76.173] (port=32889 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ld92i-000195-6s
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:10:44 -0500
Received: from mail-fx0-f175.google.com ([209.85.220.175]:33910)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Ld92h-0000dS-3n
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:10:43 -0500
Received: by fxm23 with SMTP id 23so1126686fxm.34
	for <qemu-devel@nongnu.org>; Fri, 27 Feb 2009 12:10:42 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1235756074-1719-1-git-send-email-aliguori@us.ibm.com>
References: <1235756074-1719-1-git-send-email-aliguori@us.ibm.com>
Date: Fri, 27 Feb 2009 22:10:41 +0200
Message-ID: <f43fc5580902271210x2ccd7508h6e5e79613c7d50d6@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH][RFC] Fix SDL on evdev hosts
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>

On 2/27/09, Anthony Liguori <aliguori@us.ibm.com> wrote:
> This patch corrects SDL support on X11 hosts using evdev.  It's losely based
>  on the previous patch by Dustin Kirkland and the evdev support code in gtk-vnc
>  written by Daniel Berrange.
>
>  I've tried to take into account all past feedback from previous patches posted
>  including a proper set of configure checks.  I've tested this on win32 but
>  I'd like some more eyes to look at it.
>
>  Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Just a micro nitpick:
>  +#ifndef _QEMU_X_KEYMAP_H
>  +#define _QEMU_X_KEYMAP_H
>  +
>  +extern uint8_t translate_xfree86_keycode(const int key);
>  +
>  +extern uint8_t translate_evdev_keycode(const int key);
>  +
>  +#endif
>  +

Looks like an extra newline at the end of file? ;-)

The #endif does not have the traditional /* _QEMU_X_KEYMAP_H */
ending, but I don't care much for those.