* [Qemu-devel] [PATCH] PPC64 target: Fix typo in gen_qemu_ld32s
@ 2009-02-27 22:12 Alexander Graf
2009-02-28 8:26 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Graf @ 2009-02-27 22:12 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexander Graf
When the CPU is in little endian mode, it should load values from RAM
in byte swapped manner. This check is in all the ld and st functions,
but misspelled in gen_qemu_ld32s.
This patch fixes the misspelling and makes ppc64 Linux happier.
Signed-off-by: Alexander Graf <alex@csgraf.de>
---
target-ppc/translate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index f01a1cf..2a06e4c 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -2624,7 +2624,7 @@ static always_inline void gen_qemu_ld32u(DisasContext *ctx, TCGv arg1, TCGv arg2
#if defined(TARGET_PPC64)
static always_inline void gen_qemu_ld32s(DisasContext *ctx, TCGv arg1, TCGv arg2)
{
- if (unlikely(ctx->mem_idx)) {
+ if (unlikely(ctx->le_mode)) {
TCGv_i32 t0;
tcg_gen_qemu_ld32u(arg1, arg2, ctx->mem_idx);
t0 = tcg_temp_new_i32();
--
1.6.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] PPC64 target: Fix typo in gen_qemu_ld32s
2009-02-27 22:12 [Qemu-devel] [PATCH] PPC64 target: Fix typo in gen_qemu_ld32s Alexander Graf
@ 2009-02-28 8:26 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2009-02-28 8:26 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexander Graf
On 2/28/09, Alexander Graf <agraf@suse.de> wrote:
> When the CPU is in little endian mode, it should load values from RAM
> in byte swapped manner. This check is in all the ld and st functions,
> but misspelled in gen_qemu_ld32s.
>
> This patch fixes the misspelling and makes ppc64 Linux happier.
>
> Signed-off-by: Alexander Graf <alex@csgraf.de>
Thanks, applied as r6654.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-28 8:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-27 22:12 [Qemu-devel] [PATCH] PPC64 target: Fix typo in gen_qemu_ld32s Alexander Graf
2009-02-28 8:26 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).