From: Blue Swirl <blauwirbel@gmail.com>
To: Alexander Graf <agraf@suse.de>
Cc: Alexander Graf <alex@csgraf.de>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 1/3] PPC: Circumvent overflow in mtcrf
Date: Mon, 2 Mar 2009 20:53:35 +0200 [thread overview]
Message-ID: <f43fc5580903021053t2c1faa91odab9dd8932952d99@mail.gmail.com> (raw)
In-Reply-To: <1236013674-28082-2-git-send-email-agraf@suse.de>
On 3/2/09, Alexander Graf <agraf@suse.de> wrote:
> I had a segmentation fault in mtcrf, where ffs() returned 8 and the
> code then accessed cpu_crf[7 - 8].
>
> In order to circumvent this, I just put in an & 7 to the ffs result,
> so we'll never run negative. This is probably not correct, but makes
> things work for me so far.
ffs does not return bit number (in power of 2 numbering), but one if
the zeroth bit is set, two if the first bit is set etc. So I'd try
instead
crn = ffs(crm) - 1;
next prev parent reply other threads:[~2009-03-02 18:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 17:07 [Qemu-devel] [PATCH 0/3] PPC64 Linux bringup patches Alexander Graf
2009-03-02 17:07 ` [Qemu-devel] [PATCH 1/3] PPC: Circumvent overflow in mtcrf Alexander Graf
2009-03-02 17:07 ` [Qemu-devel] [PATCH 2/3] PPC64: Implement slbmte Alexander Graf
2009-03-02 17:07 ` [Qemu-devel] [PATCH 3/3] PPC64: Implement large pages Alexander Graf
2009-03-02 18:58 ` [Qemu-devel] Re: [PATCH 2/3] PPC64: Implement slbmte Blue Swirl
2009-03-02 19:00 ` Alexander Graf
2009-03-02 19:07 ` Paul Brook
2009-03-02 19:28 ` Blue Swirl
2009-03-02 19:47 ` Alexander Graf
2009-03-02 18:53 ` Blue Swirl [this message]
2009-03-02 22:45 ` [Qemu-devel] [PATCH 1/3] PPC: Circumvent overflow in mtcrf Laurent Desnogues
2009-03-03 10:26 ` Alexander Graf
2009-03-03 10:30 ` Laurent Desnogues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580903021053t2c1faa91odab9dd8932952d99@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=agraf@suse.de \
--cc=alex@csgraf.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).