From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LftHh-00061W-Ce
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 04:57:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LftHf-00061H-9H
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 04:57:32 -0500
Received: from [199.232.76.173] (port=57577 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LftHf-00061E-64
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 04:57:31 -0500
Received: from mail-bw0-f171.google.com ([209.85.218.171]:56131)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LftHe-0006vQ-Nl
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 04:57:30 -0500
Received: by bwz19 with SMTP id 19so572182bwz.34
	for <qemu-devel@nongnu.org>; Sat, 07 Mar 2009 01:57:26 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1236353765-4484-2-git-send-email-agraf@suse.de>
References: <1236353765-4484-1-git-send-email-agraf@suse.de>
	<1236353765-4484-2-git-send-email-agraf@suse.de>
Date: Sat, 7 Mar 2009 11:57:26 +0200
Message-ID: <f43fc5580903070157x7b044963k36ad7faf6a9b30d4@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 01/11] PPC64: Implement slbmte
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Alexander Graf <alex@csgraf.de>, qemu-devel@nongnu.org

On 3/6/09, Alexander Graf <agraf@suse.de> wrote:
> In order to modify SLB entries on recent PPC64 machines, the slbmte
>  instruction is used.

>   void ppc_store_sr (CPUPPCState *env, int srnum, target_ulong value)
>   {
>      LOG_MMU("%s: reg=%d " ADDRX " " ADDRX "\n",
>                  __func__, srnum, value, env->sr[srnum]);
>  -    if (env->sr[srnum] != value) {
>  +    if (env->mmu_model & POWERPC_MMU_64) {
>  +        uint64_t rb = 0, rs = 0;

This part does not compile because POWERPC_MMU_64 is not defined, is
the patch sequence correct?