From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LftSw-0008Ej-2p for qemu-devel@nongnu.org; Sat, 07 Mar 2009 05:09:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LftSt-0008E8-BR for qemu-devel@nongnu.org; Sat, 07 Mar 2009 05:09:08 -0500 Received: from [199.232.76.173] (port=43128 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LftSt-0008E5-7k for qemu-devel@nongnu.org; Sat, 07 Mar 2009 05:09:07 -0500 Received: from mail-fx0-f175.google.com ([209.85.220.175]:40123) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LftSs-00088g-QD for qemu-devel@nongnu.org; Sat, 07 Mar 2009 05:09:06 -0500 Received: by fxm23 with SMTP id 23so592441fxm.34 for ; Sat, 07 Mar 2009 02:09:06 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <200903061112.25904.hasso@estpak.ee> References: <200903061112.25904.hasso@estpak.ee> Date: Sat, 7 Mar 2009 12:09:05 +0200 Message-ID: Subject: Re: [Qemu-devel] [PATCH] Support for DragonFly BSD From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 3/6/09, Hasso Tepper wrote: > The attached patch against trunk allows qemu to compile and work on > DragonFly BSD platform (BSD usermode emulation targets disabled though). > The patch is mostly straightforward, only few comments. > > * Missing "monitor.h" include is a recent regression in trunk and with > this snippet removed the patch applies cleanly to the 0.10.0. We can remove the console.h include as well. I'll commit my fix for this next. > * Using /usr/bin/env should be generally a good idea. Most systems besides > Linux doesn't have perl in /usr/bin. Based on the discussions, I think this part should not be applied. Other parts look OK.