qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] configure sensitive to user locale
@ 2009-03-01 18:52 Andreas Färber
  2009-03-09 17:37 ` Blue Swirl
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Färber @ 2009-03-01 18:52 UTC (permalink / raw)
  To: qemu-devel

On German Fedora 9, no KVM errors are displayed.
This is because configure greps for "error:", which is locale-sensitive.

Use LANG=C for configure to find and display errors as expected.

Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
---

diff --git a/configure b/configure
index 75e1099..780c7a1 100755
--- a/configure
+++ b/configure
@@ -999,7 +999,7 @@ EOF
      kvm="no";
      if [ -x "`which awk 2>/dev/null`" ] && \
         [ -x "`which grep 2>/dev/null`" ]; then
-      kvmerr=`$cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $kvm_cflags  
$TMPC 2>&1 \
+      kvmerr=`LANG=C $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS}  
$kvm_cflags $TMPC 2
         | grep "error: " \
         | awk -F "error: " '{if (NR>1) printf(", "); printf("%s", 
$2);}'`
        if test "$kvmerr" != "" ; then

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] configure sensitive to user locale
  2009-03-01 18:52 [Qemu-devel] [PATCH] configure sensitive to user locale Andreas Färber
@ 2009-03-09 17:37 ` Blue Swirl
  0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2009-03-09 17:37 UTC (permalink / raw)
  To: qemu-devel

On 3/1/09, Andreas Färber <andreas.faerber@web.de> wrote:
> On German Fedora 9, no KVM errors are displayed.
>  This is because configure greps for "error:", which is locale-sensitive.
>
>  Use LANG=C for configure to find and display errors as expected.
>
>  Signed-off-by: Andreas Faerber <andreas.faerber@web.de>

Thanks, applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-09 20:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-01 18:52 [Qemu-devel] [PATCH] configure sensitive to user locale Andreas Färber
2009-03-09 17:37 ` Blue Swirl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).