Re: [Qemu-devel] [PATCH] Make the ELF loader aware of backwards compatibility

[Blue Swirl <blauwirbel@gmail.com>]

On 3/12/09, Alexander Graf <alex@csgraf.de> wrote:
>
>  On 28.02.2009, at 16:30, Blue Swirl wrote:
>
>
> > On 2/28/09, Alexander Graf <agraf@suse.de> wrote:
> >
> > > Most 64 bit architectures I'm aware of support running 32 bit code
> > > of the same architecture as well.
> > >
> >
> > For Sparc64 this is only true for userland, kernel level code is not
> > compatible at all. Sparc64 kernel can run Sparc64 and Sparc32
> > binaries, but a Sparc32 kernel will crash on Sparc64.
> >
> >
> > >  /* Load a 32 bit BIOS also on 64 bit machines */
> > > -#if defined (TARGET_PPC64) && defined(CONFIG_USER_ONLY)
> > > +#if defined (TARGET_PPC64)
> > >  #define ELF_MACHINE     EM_PPC64
> > >  #else
> > >  #define ELF_MACHINE     EM_PPC
> > >
> >
> > The comment should be removed with the hack.
> >
>
>  I agree.
>
>  Any functional issues with this patch? -kernel for ppc64 still doesn't work
> with current SVN :-).

The elf_check_arch macro that linux-user uses could be cleaner
approach. But this is OK as the first step, so I'll commit this
shortly.