From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LiBXU-0006Jk-St
	for qemu-devel@nongnu.org; Fri, 13 Mar 2009 13:51:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LiBXP-0006G0-JN
	for qemu-devel@nongnu.org; Fri, 13 Mar 2009 13:51:19 -0400
Received: from [199.232.76.173] (port=33692 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LiBXP-0006Fv-FT
	for qemu-devel@nongnu.org; Fri, 13 Mar 2009 13:51:15 -0400
Received: from mail-fx0-f161.google.com ([209.85.220.161]:49851)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LiBXP-0007n8-05
	for qemu-devel@nongnu.org; Fri, 13 Mar 2009 13:51:15 -0400
Received: by fxm5 with SMTP id 5so288857fxm.34
	for <qemu-devel@nongnu.org>; Fri, 13 Mar 2009 10:51:13 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1236954043-91856-21-git-send-email-gingold@adacore.com>
References: <1236954043-91856-1-git-send-email-gingold@adacore.com>
	<1236954043-91856-13-git-send-email-gingold@adacore.com>
	<1236954043-91856-14-git-send-email-gingold@adacore.com>
	<1236954043-91856-15-git-send-email-gingold@adacore.com>
	<1236954043-91856-16-git-send-email-gingold@adacore.com>
	<1236954043-91856-17-git-send-email-gingold@adacore.com>
	<1236954043-91856-18-git-send-email-gingold@adacore.com>
	<1236954043-91856-19-git-send-email-gingold@adacore.com>
	<1236954043-91856-20-git-send-email-gingold@adacore.com>
	<1236954043-91856-21-git-send-email-gingold@adacore.com>
Date: Fri, 13 Mar 2009 19:51:13 +0200
Message-ID: <f43fc5580903131051u52c78726jb8147e931dd1c3c0@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 20/24] Add alpha_cpu_list.
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 3/13/09, Tristan Gingold <gingold@adacore.com> wrote:
> Add alpha_cpu_list and use cpu_model to select the model in cpu_alpha_init.
>  Set implver and amask from the model.
>
>  Signed-off-by: Tristan Gingold <gingold@adacore.com>

>  +static struct alpha_def alpha_defs[] = {

"const"

>  +#if 0
>  +    { "21064", IMPLVER_2106x, 0 },
>  +    { "21164", IMPLVER_21164, 0 },
>  +#endif
>  +    { "21264", IMPLVER_21264, (AMASK_PREFETCH | AMASK_TRAP | AMASK_BWX
>  +                               | AMASK_FIX) },
>  +    { NULL, 0 }
>  +};

I'd use ARRAY_SIZE macro to determine the size of table for indexing
instead of no NULL termination, but this style is also widely used.