[Qemu-devel] QEMU help output broken

[Qemu-devel] QEMU help output broken

[Anthony Liguori]

DEFOPTION() is turning the \n into a 'n' so everything ends up on the 
same line.

gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) (GCC)

Passing arbitrary text into a macro looks very fishy to me.  CPP still 
uses a C tokenizer IIRC so you need at least lexically correct C.

Regards,

Anthony Liguori

[Qemu-devel] Re: QEMU help output broken

[Blue Swirl]

On 3/28/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> DEFOPTION() is turning the \n into a 'n' so everything ends up on the same
> line.
>
>  gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) (GCC)
>
>  Passing arbitrary text into a macro looks very fishy to me.  CPP still uses
> a C tokenizer IIRC so you need at least lexically correct C.

No, it's a problem with the shell script parser hxtool. The text is
already broken in the parsed file (for example sparc-softmmu/)
qemu-options.h:

DEF("M", HAS_ARG, QEMU_OPTION_M,
"-M machine select emulated machine (-M ? for list)n")

I'm pretty certain that both Perl and C hxtool parsers did work.

[Qemu-devel] Re: QEMU help output broken

[Blue Swirl]

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

On 3/28/09, Blue Swirl <blauwirbel@gmail.com> wrote:
> On 3/28/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
>  > DEFOPTION() is turning the \n into a 'n' so everything ends up on the same
>  > line.
>  >
>  >  gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) (GCC)
>  >
>  >  Passing arbitrary text into a macro looks very fishy to me.  CPP still uses
>  > a C tokenizer IIRC so you need at least lexically correct C.
>
>
> No, it's a problem with the shell script parser hxtool. The text is
>  already broken in the parsed file (for example sparc-softmmu/)
>  qemu-options.h:
>
>  DEF("M", HAS_ARG, QEMU_OPTION_M,
>  "-M machine select emulated machine (-M ? for list)n")
>
>  I'm pretty certain that both Perl and C hxtool parsers did work.

This patch fixes the problem, but only for sh == bash case.

[-- Attachment #2: fix_hxtool_munging.diff --]
[-- Type: plain/text, Size: 713 bytes --]

Re: [Qemu-devel] Re: QEMU help output broken

[malc]

On Sat, 28 Mar 2009, Blue Swirl wrote:

> On 3/28/09, Blue Swirl <blauwirbel@gmail.com> wrote:
> > On 3/28/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> >  > DEFOPTION() is turning the \n into a 'n' so everything ends up on the same
> >  > line.
> >  >
> >  >  gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) (GCC)
> >  >
> >  >  Passing arbitrary text into a macro looks very fishy to me.  CPP still uses
> >  > a C tokenizer IIRC so you need at least lexically correct C.
> >
> >
> > No, it's a problem with the shell script parser hxtool. The text is
> >  already broken in the parsed file (for example sparc-softmmu/)
> >  qemu-options.h:
> >
> >  DEF("M", HAS_ARG, QEMU_OPTION_M,
> >  "-M machine select emulated machine (-M ? for list)n")
> >
> >  I'm pretty certain that both Perl and C hxtool parsers did work.
> 
> This patch fixes the problem, but only for sh == bash case.

No, it should be fine everywhere:
http://www.opengroup.org/onlinepubs/000095399/utilities/read.html 

-- 
mailto:av1474@comtv.ru