From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LnemH-0002Xq-BR for qemu-devel@nongnu.org; Sat, 28 Mar 2009 16:05:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LnemC-0002XK-Pi for qemu-devel@nongnu.org; Sat, 28 Mar 2009 16:05:12 -0400 Received: from [199.232.76.173] (port=50176 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LnemC-0002XH-Mf for qemu-devel@nongnu.org; Sat, 28 Mar 2009 16:05:08 -0400 Received: from mail-fx0-f169.google.com ([209.85.220.169]:62053) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LnemB-0004cN-LN for qemu-devel@nongnu.org; Sat, 28 Mar 2009 16:05:07 -0400 Received: by fxm17 with SMTP id 17so1324857fxm.34 for ; Sat, 28 Mar 2009 13:05:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <49CE784C.2040306@codemonkey.ws> References: <49CE784C.2040306@codemonkey.ws> Date: Sat, 28 Mar 2009 22:05:05 +0200 Message-ID: From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: QEMU help output broken Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 3/28/09, Anthony Liguori wrote: > DEFOPTION() is turning the \n into a 'n' so everything ends up on the same > line. > > gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) (GCC) > > Passing arbitrary text into a macro looks very fishy to me. CPP still uses > a C tokenizer IIRC so you need at least lexically correct C. No, it's a problem with the shell script parser hxtool. The text is already broken in the parsed file (for example sparc-softmmu/) qemu-options.h: DEF("M", HAS_ARG, QEMU_OPTION_M, "-M machine select emulated machine (-M ? for list)n") I'm pretty certain that both Perl and C hxtool parsers did work.