From: Blue Swirl <blauwirbel@gmail.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: QEMU help output broken
Date: Sat, 28 Mar 2009 22:19:17 +0200 [thread overview]
Message-ID: <f43fc5580903281319gcbb34eas2079266191e4dfb0@mail.gmail.com> (raw)
In-Reply-To: <f43fc5580903281305r5845c478w4170a44b1924af5b@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On 3/28/09, Blue Swirl <blauwirbel@gmail.com> wrote:
> On 3/28/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> > DEFOPTION() is turning the \n into a 'n' so everything ends up on the same
> > line.
> >
> > gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) (GCC)
> >
> > Passing arbitrary text into a macro looks very fishy to me. CPP still uses
> > a C tokenizer IIRC so you need at least lexically correct C.
>
>
> No, it's a problem with the shell script parser hxtool. The text is
> already broken in the parsed file (for example sparc-softmmu/)
> qemu-options.h:
>
> DEF("M", HAS_ARG, QEMU_OPTION_M,
> "-M machine select emulated machine (-M ? for list)n")
>
> I'm pretty certain that both Perl and C hxtool parsers did work.
This patch fixes the problem, but only for sh == bash case.
[-- Attachment #2: fix_hxtool_munging.diff --]
[-- Type: plain/text, Size: 713 bytes --]
next prev parent reply other threads:[~2009-03-28 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-28 19:19 [Qemu-devel] QEMU help output broken Anthony Liguori
2009-03-28 20:05 ` [Qemu-devel] " Blue Swirl
2009-03-28 20:19 ` Blue Swirl [this message]
2009-03-28 22:18 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580903281319gcbb34eas2079266191e4dfb0@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).