From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lnezz-0001fR-Oq for qemu-devel@nongnu.org; Sat, 28 Mar 2009 16:19:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lnezv-0001bW-6k for qemu-devel@nongnu.org; Sat, 28 Mar 2009 16:19:23 -0400 Received: from [199.232.76.173] (port=52425 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lnezv-0001bT-2v for qemu-devel@nongnu.org; Sat, 28 Mar 2009 16:19:19 -0400 Received: from mail-bw0-f172.google.com ([209.85.218.172]:34478) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lnezu-000639-MT for qemu-devel@nongnu.org; Sat, 28 Mar 2009 16:19:18 -0400 Received: by bwz20 with SMTP id 20so1316405bwz.34 for ; Sat, 28 Mar 2009 13:19:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <49CE784C.2040306@codemonkey.ws> Date: Sat, 28 Mar 2009 22:19:17 +0200 Message-ID: From: Blue Swirl Content-Type: multipart/mixed; boundary=001636c5a43554dfec04663390a9 Subject: [Qemu-devel] Re: QEMU help output broken Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org --001636c5a43554dfec04663390a9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/28/09, Blue Swirl wrote: > On 3/28/09, Anthony Liguori wrote: > > DEFOPTION() is turning the \n into a 'n' so everything ends up on the same > > line. > > > > gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) (GCC) > > > > Passing arbitrary text into a macro looks very fishy to me. CPP still uses > > a C tokenizer IIRC so you need at least lexically correct C. > > > No, it's a problem with the shell script parser hxtool. The text is > already broken in the parsed file (for example sparc-softmmu/) > qemu-options.h: > > DEF("M", HAS_ARG, QEMU_OPTION_M, > "-M machine select emulated machine (-M ? for list)n") > > I'm pretty certain that both Perl and C hxtool parsers did work. This patch fixes the problem, but only for sh == bash case. --001636c5a43554dfec04663390a9 Content-Type: plain/text; name="fix_hxtool_munging.diff" Content-Disposition: attachment; filename="fix_hxtool_munging.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fsuqwm0h SW5kZXg6IHFlbXUvaHh0b29sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9oeHRvb2wJMjAwOS0w My0yOCAyMDowNTo1OC4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvaHh0b29sCTIwMDktMDMtMjgg MjA6MTU6MjguMDAwMDAwMDAwICswMDAwCkBAIC0zLDE0ICszLDE0IEBACiBoeHRvaCgpCiB7CiAg ICAgZmxhZz0xCi0gICAgd2hpbGUgcmVhZCBzdHI7IGRvCisgICAgd2hpbGUgcmVhZCAtciBzdHI7 IGRvCiAgICAgICAgIGNhc2UgJHN0ciBpbgogICAgICAgICAgICAgSFhDT01NKikKICAgICAgICAg ICAgIDs7CiAgICAgICAgICAgICBTVEVYSSp8RVRFWEkqKSBmbGFnPSQoKCRmbGFnXjEpKQogICAg ICAgICAgICAgOzsKICAgICAgICAgICAgICopCi0gICAgICAgICAgICB0ZXN0ICRmbGFnIC1lcSAx ICYmIGVjaG8gJHN0cgorICAgICAgICAgICAgdGVzdCAkZmxhZyAtZXEgMSAmJiBlY2hvICIkc3Ry IgogICAgICAgICAgICAgOzsKICAgICAgICAgZXNhYwogICAgIGRvbmUKQEAgLTE5LDcgKzE5LDcg QEAKIGh4dG90ZXhpKCkKIHsKICAgICBmbGFnPTAKLSAgICB3aGlsZSByZWFkIHN0cjsgZG8KKyAg ICB3aGlsZSByZWFkIC1yIHN0cjsgZG8KICAgICAgICAgY2FzZSAiJHN0ciIgaW4KICAgICAgICAg ICAgIEhYQ09NTSopCiAgICAgICAgICAgICA7Owo= --001636c5a43554dfec04663390a9--