qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] sending NUMA topology to BIOS
Date: Tue, 31 Mar 2009 19:00:10 +0300	[thread overview]
Message-ID: <f43fc5580903310900m5c8c3959xe0b1e0b804f7648c@mail.gmail.com> (raw)
In-Reply-To: <1238506137-9140-4-git-send-email-andre.przywara@amd.com>

On 3/31/09, Andre Przywara <andre.przywara@amd.com> wrote:
> From: Andre Przywara <aprzywar@amd.com>
>
>
>  Signed-off-by: Andre Przywara <andre.przywara@amd.com>


>   static void bochs_bios_init(void)

>  +    uint64_t *numa_fw_cfg;

>  +                numa_fw_cfg[i + 1] = j;

>  +        numa_fw_cfg[smp_cpus + 1 + i] = node_mem[i];

>  +    fw_cfg_add_bytes(fw_cfg, FW_CFG_NUMA, (uint8_t*)numa_fw_cfg,
>  +                     (1 + smp_cpus + nb_numa_nodes) * 8);

This would break on a big endian host, please use cpu_to_le64.

  parent reply	other threads:[~2009-03-31 16:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31 13:28 [Qemu-devel] [PATCH 0/4] add NUMA emulation Andre Przywara
2009-03-31 13:28 ` [Qemu-devel] [PATCH 1/4] added -numa cmdline parameter parser Andre Przywara
2009-03-31 13:28   ` [Qemu-devel] [PATCH 2/4] add info numa command to monitor Andre Przywara
2009-03-31 13:28     ` [Qemu-devel] [PATCH 3/4] sending NUMA topology to BIOS Andre Przywara
2009-03-31 13:28       ` [Qemu-devel] [PATCH 4/4] add BIOS support for an ACPI SRAT table (needed for NUMA support) Andre Przywara
2009-03-31 13:44         ` [Qemu-devel] " Anthony Liguori
2009-03-31 20:04           ` [Qemu-devel] [PATCH 4/4] add SRAT ACPI table support Andre Przywara
2009-03-31 16:00       ` Blue Swirl [this message]
2009-03-31 21:33         ` [Qemu-devel] [PATCH 3/4] sending NUMA topology to BIOS Andre Przywara
2009-03-31 13:42   ` [Qemu-devel] Re: [PATCH 1/4] added -numa cmdline parameter parser Anthony Liguori
2009-03-31 20:34     ` Andre Przywara
2009-03-31 14:37 ` [Qemu-devel] Re: [PATCH 0/4] add NUMA emulation Anthony Liguori
  -- strict thread matches above, loose matches on Subject: below --
2009-04-08 14:50 [Qemu-devel] [PATCH 0/4] v2: " Andre Przywara
2009-04-08 14:50 ` [Qemu-devel] [PATCH 3/4] sending NUMA topology to BIOS Andre Przywara
2009-04-21 11:02 [Qemu-devel] [PATCH 0/4] v3: add NUMA emulation Andre Przywara
2009-04-21 11:02 ` [Qemu-devel] [PATCH 3/4] sending NUMA topology to BIOS Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580903310900m5c8c3959xe0b1e0b804f7648c@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).