From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LpQ6g-0008Gh-Ew
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 12:49:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LpQ6b-0008FE-Uf
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 12:49:34 -0400
Received: from [199.232.76.173] (port=57555 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LpQ6b-0008F0-K6
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 12:49:29 -0400
Received: from fk-out-0910.google.com ([209.85.128.185]:40290)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LpQ6b-0006WI-7R
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 12:49:29 -0400
Received: by fk-out-0910.google.com with SMTP id z22so268109fkz.2
	for <qemu-devel@nongnu.org>; Thu, 02 Apr 2009 09:49:28 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1238621982-18333-3-git-send-email-kraxel@redhat.com>
References: <1238621982-18333-1-git-send-email-kraxel@redhat.com>
	<1238621982-18333-3-git-send-email-kraxel@redhat.com>
Date: Thu, 2 Apr 2009 19:49:27 +0300
Message-ID: <f43fc5580904020949m15a70403rcb44c50937ae647a@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 02/10] xen: backend driver core
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com, Gerd Hoffmann <kraxel@redhat.com>

On 4/2/09, Gerd Hoffmann <kraxel@redhat.com> wrote:
> This patch adds infrastructure for xen backend drivers living in qemu,
>  so drivers don't need to implement common stuff on their own.  It's
>  mostly xenbus management stuff: some functions to access xentore,
>  setting up xenstore watches, callbacks on device discovery and state
>  changes, handle event channel, ...
>
>  Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

>  + *  You should have received a copy of the GNU General Public License
>  + *  along with this program; if not, write to the Free Software
>  + *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

The address is now 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

>  +    if (NULL == node  ||  0 == strcmp(node, "online")) {
>  +       if (-1 == xenstore_read_be_int(xendev, "online", &xendev->online))

This style is alien.