From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LpQEk-0002Np-N9
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 12:57:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LpQEf-0002Jq-Uh
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 12:57:53 -0400
Received: from [199.232.76.173] (port=33285 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LpQEf-0002Jn-MM
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 12:57:49 -0400
Received: from mail-bw0-f172.google.com ([209.85.218.172]:40955)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LpQEf-0007eJ-79
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 12:57:49 -0400
Received: by bwz20 with SMTP id 20so555110bwz.34
	for <qemu-devel@nongnu.org>; Thu, 02 Apr 2009 09:57:48 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1238621982-18333-5-git-send-email-kraxel@redhat.com>
References: <1238621982-18333-1-git-send-email-kraxel@redhat.com>
	<1238621982-18333-5-git-send-email-kraxel@redhat.com>
Date: Thu, 2 Apr 2009 19:57:48 +0300
Message-ID: <f43fc5580904020957u4867dd7blfe0d0a9c460b4f08@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 04/10] xen: add framebuffer backend driver
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com, Gerd Hoffmann <kraxel@redhat.com>

On 4/2/09, Gerd Hoffmann <kraxel@redhat.com> wrote:
> This patch adds a frsamebuffer (and kbd+mouse) backend driver.  It
>  it based on current xen-unstable code.  It has been changed to make
>  use of the common backend driver code.  It also has been changed to
>  compile with xen headers older than release 3.3
>
>  Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

>  +    pgmfns = qemu_mallocz(sizeof(unsigned long) * n_fbdirs);
>  +    fbmfns = qemu_mallocz(sizeof(unsigned long) * xenfb->fbpages);
>  +    if (!pgmfns || !fbmfns)
>  +       goto out;

This check should be removed, qemu_malloc will abort if we're out of memory.