From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LpQNc-0007ma-Cq
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 13:07:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LpQNX-0007ca-Nv
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 13:07:03 -0400
Received: from [199.232.76.173] (port=44035 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LpQNX-0007cO-KW
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 13:06:59 -0400
Received: from mail-bw0-f172.google.com ([209.85.218.172]:41933)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LpQNX-0000IS-3T
	for qemu-devel@nongnu.org; Thu, 02 Apr 2009 13:06:59 -0400
Received: by bwz20 with SMTP id 20so558881bwz.34
	for <qemu-devel@nongnu.org>; Thu, 02 Apr 2009 10:06:57 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1238621982-18333-9-git-send-email-kraxel@redhat.com>
References: <1238621982-18333-1-git-send-email-kraxel@redhat.com>
	<1238621982-18333-9-git-send-email-kraxel@redhat.com>
Date: Thu, 2 Apr 2009 20:06:57 +0300
Message-ID: <f43fc5580904021006o2c731fa9if27c3ffe8db4eba3@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 08/10] xen: pv domain builder.
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com, Gerd Hoffmann <kraxel@redhat.com>

On 4/2/09, Gerd Hoffmann <kraxel@redhat.com> wrote:
> This adds domain building support for paravirtual domains to qemu.
>  This allows booting xen guests directly with qemu, without Xend
>  and the management stack.
>
>  Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

>  +    /* close all file handles, except stdio/out/err,
>  +     * our watch pipe and the xen interface handle */
>  +    for (i = 3; i < 256; i++) {

You should use getdtablesize() or sysconf(_SC_OPEN_MAX) instead of 256.