[Qemu-devel] Using GNU windres in QEMU

[Qemu-devel] Using GNU windres in QEMU

[Robert Riebisch]

Hi!

What's the best (easy to understand, flexible) solution to add a quiet
call GNU to windres?

Here's what I have for rules.mak:

%.o: %.rc
	$(call quiet-command,${cross_prefix}windres -I. -I..
-DWIN32_QEMU_FILENAME='\"$(QEMU_PROG)\"' -o $@ $<,"  RC    $(TARGET_DIR)$@")

Again I'm working on adding icon and VERSIONINFO resources to QEMU's EXE
files and this time I'd like to see this included to QEMU trunk. ;-)

Adding resources to qemu.exe or qemu-system-x86_64.exe already works.
qemu-img still to do.

Robert Riebisch
-- 
BTTR Software
http://www.bttr-software.de/

Re: [Qemu-devel] Using GNU windres in QEMU

[C.W. Betts]

[-- Attachment #1: Type: text/plain, Size: 2318 bytes --]

Here's my work:
Index: Makefile.target
===================================================================
--- Makefile.target	(revision 6970)
+++ Makefile.target	(working copy)
@@ -726,6 +728,7 @@

  ifdef CONFIG_WIN32
  SDL_LIBS := $(filter-out -mwindows, $(SDL_LIBS)) -mconsole
+OBJS+=version.o
  endif

  # profiling code
Index: configure
===================================================================
--- configure	(revision 6970)
+++ configure	(working copy)
@@ -1620,6 +1620,10 @@
  echo "# Automatically generated by configure - do not modify" >  
$config_mak
  echo "/* Automatically generated by configure - do not modify */" >  
$config_h

+if test "$mingw32" = "yes" ; then
+echo "#define QEMU_FILEVERSION $(tr . , < $source_path/VERSION),0" >>  
$config_h
+echo "#define QEMU_PRODUCTVERSION $(tr . , < $source_path/VERSION),0"  
 >> $config_h
+fi

  echo "include ../config-host.mak" >> $config_mak
  echo "#include \"../config-host.h\"" >> $config_h
Index: version.rc
===================================================================
--- /dev/null	2009-04-03 20:26:26.000000000 -0600
+++ version.rc	2008-03-30 18:25:52.000000000 -0600
@@ -0,0 +1,22 @@
+#include "config.h"
+
+1 VERSIONINFO
+FILEVERSION QEMU_FILEVERSION
+PRODUCTVERSION QEMU_PRODUCTVERSION
+FILETYPE 0x1 //VFT_APP
+ {
+BLOCK "StringFileInfo"
+  {
+  BLOCK "040904E4"
+  {
+   VALUE "FileDescription", "Qemu System emulator, " TARGET_ARCH "  
version"
+   VALUE "FileVersion", QEMU_VERSION
+   VALUE "LegalCopyright", "GNU General Public License"
+   VALUE "ProductName", "Qemu"
+  }
+ }
+BLOCK "VarFileInfo"
+ {
+  VALUE "Translation", 0x0409, 1252
+ }
+}
On Mar 31, 2009, at 3:03 PM, Robert Riebisch wrote:

> Hi!
>
> What's the best (easy to understand, flexible) solution to add a quiet
> call GNU to windres?
>
> Here's what I have for rules.mak:
>
> %.o: %.rc
> 	$(call quiet-command,${cross_prefix}windres -I. -I..
> -DWIN32_QEMU_FILENAME='\"$(QEMU_PROG)\"' -o $@ $<,"  RC    $ 
> (TARGET_DIR)$@")
>
> Again I'm working on adding icon and VERSIONINFO resources to QEMU's  
> EXE
> files and this time I'd like to see this included to QEMU trunk. ;-)
>
> Adding resources to qemu.exe or qemu-system-x86_64.exe already works.
> qemu-img still to do.
>
> Robert Riebisch
> -- 
> BTTR Software
> http://www.bttr-software.de/
>
>

[-- Attachment #2.1: Type: text/html, Size: 3748 bytes --]

[-- Attachment #2.2: qemurc.diff --]
[-- Type: application/octet-stream, Size: 1612 bytes --]

Index: Makefile.target
===================================================================
--- Makefile.target	(revision 6970)
+++ Makefile.target	(working copy)
@@ -726,6 +728,7 @@
 
 ifdef CONFIG_WIN32
 SDL_LIBS := $(filter-out -mwindows, $(SDL_LIBS)) -mconsole
+OBJS+=version.o
 endif
 
 # profiling code
Index: configure
===================================================================
--- configure	(revision 6970)
+++ configure	(working copy)
@@ -1620,6 +1620,10 @@
 echo "# Automatically generated by configure - do not modify" > $config_mak
 echo "/* Automatically generated by configure - do not modify */" > $config_h
 
+if test "$mingw32" = "yes" ; then
+echo "#define QEMU_FILEVERSION $(tr . , < $source_path/VERSION),0" >> $config_h
+echo "#define QEMU_PRODUCTVERSION $(tr . , < $source_path/VERSION),0" >> $config_h
+fi
 
 echo "include ../config-host.mak" >> $config_mak
 echo "#include \"../config-host.h\"" >> $config_h
Index: version.rc
===================================================================
--- /dev/null	2009-04-03 20:26:26.000000000 -0600
+++ version.rc	2008-03-30 18:25:52.000000000 -0600
@@ -0,0 +1,22 @@
+#include "config.h"
+
+1 VERSIONINFO
+FILEVERSION QEMU_FILEVERSION
+PRODUCTVERSION QEMU_PRODUCTVERSION
+FILETYPE 0x1 //VFT_APP
+ {
+BLOCK "StringFileInfo"
+  {
+  BLOCK "040904E4"
+  {
+   VALUE "FileDescription", "Qemu System emulator, " TARGET_ARCH " version"
+   VALUE "FileVersion", QEMU_VERSION
+   VALUE "LegalCopyright", "GNU General Public License"
+   VALUE "ProductName", "Qemu"
+  }
+ }
+BLOCK "VarFileInfo"
+ {
+  VALUE "Translation", 0x0409, 1252
+ }
+}

[-- Attachment #2.3: Type: text/html, Size: 123 bytes --]

Re: [Qemu-devel] Using GNU windres in QEMU

[Blue Swirl]

On 4/4/09, C.W. Betts <computers57@hotmail.com> wrote:
>
> Here's my work:

> +   VALUE "FileDescription", "Qemu System emulator, " TARGET_ARCH " version"

QEMU

> +   VALUE "ProductName", "Qemu"

QEMU

Re: [Qemu-devel] Using GNU windres in QEMU

[Robert Riebisch]

C.W. Betts wrote:

[snip]

I don't see any windres call in your code?!

Robert Riebisch
-- 
BTTR Software
http://www.bttr-software.de/