From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lrd1g-0005pr-Rt for qemu-devel@nongnu.org; Wed, 08 Apr 2009 15:01:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lrd1b-0005kx-Vu for qemu-devel@nongnu.org; Wed, 08 Apr 2009 15:01:32 -0400 Received: from [199.232.76.173] (port=36099 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lrd1b-0005kc-MS for qemu-devel@nongnu.org; Wed, 08 Apr 2009 15:01:27 -0400 Received: from mail-bw0-f172.google.com ([209.85.218.172]:43861) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lrd1b-0008Ol-6F for qemu-devel@nongnu.org; Wed, 08 Apr 2009 15:01:27 -0400 Received: by bwz20 with SMTP id 20so251966bwz.34 for ; Wed, 08 Apr 2009 12:01:24 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1239215702-23818-2-git-send-email-aliguori@us.ibm.com> References: <1239215702-23818-1-git-send-email-aliguori@us.ibm.com> <1239215702-23818-2-git-send-email-aliguori@us.ibm.com> Date: Wed, 8 Apr 2009 22:01:24 +0300 Message-ID: Subject: Re: [Qemu-devel] [PATCH 2/6] Introduce monitor 'wait' command (v2) From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Anthony Liguori , Jan Kiszka , Hollis Blanchard On 4/8/09, Anthony Liguori wrote: > The wait command will pause the monitor the command was issued in until a new > event becomes available. Events are queued if there isn't a waiter present. > The wait command completes after a single event is available. > + if (!w->polling) > + monitor_resume(w->mon); CODING_STYLE, chapter 4: "Every indented statement is braced; even if the block contains just one statement." ;-)