From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LsB72-0003Pk-Ty
	for qemu-devel@nongnu.org; Fri, 10 Apr 2009 03:25:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LsB6x-0003OD-ID
	for qemu-devel@nongnu.org; Fri, 10 Apr 2009 03:25:19 -0400
Received: from [199.232.76.173] (port=42922 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LsB6x-0003O8-B4
	for qemu-devel@nongnu.org; Fri, 10 Apr 2009 03:25:15 -0400
Received: from mail-fx0-f169.google.com ([209.85.220.169]:50350)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LsB6x-0006gA-0f
	for qemu-devel@nongnu.org; Fri, 10 Apr 2009 03:25:15 -0400
Received: by fxm17 with SMTP id 17so856664fxm.34
	for <qemu-devel@nongnu.org>; Fri, 10 Apr 2009 00:25:12 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1239310201-24519-1-git-send-email-agraf@suse.de>
References: <1239310201-24519-1-git-send-email-agraf@suse.de>
Date: Fri, 10 Apr 2009 10:25:12 +0300
Message-ID: <f43fc5580904100025g6921dc74o6a6abcc050a9b32b@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 4/9/09, Alexander Graf <agraf@suse.de> wrote:
> Currently Qemu can read from posix I/O and NBD. This patch adds a
>  third protocol to the game: HTTP.
>
>  In certain situations it can be useful to access HTTP data directly,
>  for example if you want to try out an http provided OS image, but
>  don't know if you want to download it yet.
>
>  Using this patch you can now try it on on the fly. Just use it like:
>
>  qemu -cdrom http://host/path/my.iso
>
>  In order to not reinvent the wheel, this patch uses libcurl.
>
>  Warning:
>
>  With stock qemu I do get segmentation faults accessing http backed
>  files, with kvm-userspace's IO threads I don't. I haven't tracked
>  down why exactly that happens though.
>
>  Signed-off-by: Alexander Graf <agraf@suse.de>

The docs should be updated as well.

>  +    sprintf(s->range, "%lld-%lld", start, end);

Please use snprintf.