From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LtPi3-00049N-U4
	for qemu-devel@nongnu.org; Mon, 13 Apr 2009 13:12:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LtPhz-00048R-EX
	for qemu-devel@nongnu.org; Mon, 13 Apr 2009 13:12:39 -0400
Received: from [199.232.76.173] (port=32916 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LtPhz-00048O-8U
	for qemu-devel@nongnu.org; Mon, 13 Apr 2009 13:12:35 -0400
Received: from mail-fx0-f169.google.com ([209.85.220.169]:41291)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LtPhy-000122-SY
	for qemu-devel@nongnu.org; Mon, 13 Apr 2009 13:12:35 -0400
Received: by fxm17 with SMTP id 17so1909625fxm.34
	for <qemu-devel@nongnu.org>; Mon, 13 Apr 2009 10:12:33 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <49E36E8A.40005@codemonkey.ws>
References: <E1LtOwM-0007Qt-SM@cvs.savannah.gnu.org>
	<49E36E8A.40005@codemonkey.ws>
Date: Mon, 13 Apr 2009 20:12:33 +0300
Message-ID: <f43fc5580904131012p7a5b6929w981762212c871ef4@mail.gmail.com>
Subject: Re: [Qemu-devel] [7101] Skip KVM probe for OpenSolaris
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 4/13/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Blue Swirl wrote:
>
> > Revision: 7101
> >
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7101
> > Author:   blueswir1
> > Date:     2009-04-13 16:23:22 +0000 (Mon, 13 Apr 2009)
> > Log Message:
> > -----------
> > Skip KVM probe for OpenSolaris
> >
> >
>
>  The detection of "Solaris" depends on uname output.  This breaks if you're
> cross compiling.

Maybe I should add the compile time check for OpenSolaris and OpenBSD.

>  Concretely, if you attempted to cross compile QEMU for Linux in a Solaris
> environment, this patch would break KVM support.
>
>  Was this a reason to disable this problem other than it being
> "unnecessary"?

Yes, but also native awk doesn't support -F switch with a regexp
instead of single character and I must confess that I don't know
enough awk to fix it other way.