[Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Aurelien Jarno]

For historical reasons, qemu system on i386 is called qemu instead of
qemu-system-i386. This seems to confuse users.

This patch installs it as qemu-system-i386, and create a compatibility
symlink qemu -> qemu-system-i386 as some tools may call it that way.
We can change or remove this symlink after a few releases when all the
tools have migrated to this new name.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 Makefile.target |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/Makefile.target b/Makefile.target
index dae339b..88c7a32 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -63,12 +63,8 @@ ifdef CONFIG_USER_ONLY
 QEMU_PROG=qemu-$(TARGET_ARCH2)
 else
 # system emulator name
-ifeq ($(TARGET_ARCH), i386)
-QEMU_PROG=qemu$(EXESUF)
-else
 QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
 endif
-endif
 
 PROGS=$(QEMU_PROG)
 
@@ -743,6 +739,9 @@ install: all
 ifneq ($(PROGS),)
 	$(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
 endif
+ifeq ($(TARGET_ARCH), i386)
+	ln -sf qemu-system-i386$(EXESUF) "$(DESTDIR)$(bindir)/qemu$(EXESUF)"
+endif
 
 # Include automatically generated dependency files
 -include $(wildcard *.d */*.d)
-- 
1.6.1.3


-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Anthony Liguori]

Aurelien Jarno wrote:
> For historical reasons, qemu system on i386 is called qemu instead of
> qemu-system-i386. This seems to confuse users.
>
> This patch installs it as qemu-system-i386, and create a compatibility
> symlink qemu -> qemu-system-i386 as some tools may call it that way.
> We can change or remove this symlink after a few releases when all the
> tools have migrated to this new name.
>   

I agree.

Regards,

Anthony Liguori

> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  Makefile.target |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index dae339b..88c7a32 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -63,12 +63,8 @@ ifdef CONFIG_USER_ONLY
>  QEMU_PROG=qemu-$(TARGET_ARCH2)
>  else
>  # system emulator name
> -ifeq ($(TARGET_ARCH), i386)
> -QEMU_PROG=qemu$(EXESUF)
> -else
>  QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
>  endif
> -endif
>  
>  PROGS=$(QEMU_PROG)
>  
> @@ -743,6 +739,9 @@ install: all
>  ifneq ($(PROGS),)
>  	$(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
>  endif
> +ifeq ($(TARGET_ARCH), i386)
> +	ln -sf qemu-system-i386$(EXESUF) "$(DESTDIR)$(bindir)/qemu$(EXESUF)"
> +endif
>  
>  # Include automatically generated dependency files
>  -include $(wildcard *.d */*.d)
>   

Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Stefan Weil]

Anthony Liguori schrieb:
> Aurelien Jarno wrote:
>> For historical reasons, qemu system on i386 is called qemu instead of
>> qemu-system-i386. This seems to confuse users.
>>
>> This patch installs it as qemu-system-i386, and create a compatibility
>> symlink qemu -> qemu-system-i386 as some tools may call it that way.
>> We can change or remove this symlink after a few releases when all the
>> tools have migrated to this new name.
>>   
>
> I agree.
>
> Regards,
>
> Anthony Liguori
>
I agree partially.

For the current situation, qemu-system-i386 is reasonable,
and a symbolic link to qemu for non-Windows platforms is
a good solution.

For the (maybe far) future, I'd prefer to have a qemu executable
which is either a frontend to the different user and system
emulation executables or which replaces all these executables.

This new qemu could auto-detect the target architecture
from -M (cpu parameter) or from ELF file argument.
It could also auto-detect user or system mode.
Calling the correct backend qemu-xxx is then straight forward.

And finally, keeping qemu (with enhanced functionality)
would also allow to keep the existing documentation unchanged:
qemu-doc.texi has lots of references to qemu!

Regards,

Stefan Weil

Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[andrzej zaborowski]

2009/4/19 Stefan Weil <weil@mail.berlios.de>:
> For the current situation, qemu-system-i386 is reasonable,
> and a symbolic link to qemu for non-Windows platforms is
> a good solution.

Another point is that if you just download the new qemu tarball, build
it and install, the old /usr/local/bin/qemu binary will not be
overwritten if we don't create the symlink and a number of poeple will
think they're on a newer version than they're really using.

Cheers

Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Andreas Färber]

Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:

> For historical reasons, qemu system on i386 is called qemu instead of
> qemu-system-i386. This seems to confuse users.
>
> This patch installs it as qemu-system-i386, and create a compatibility
> symlink qemu -> qemu-system-i386 as some tools may call it that way.
> We can change or remove this symlink after a few releases when all the
> tools have migrated to this new name.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

In general a good idea imo, but don't just assume you can create  
symlinks on a given file system. Git uses hardlinks and copying as  
fallbacks iirc.

Andreas

>
> ---
> Makefile.target |    7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index dae339b..88c7a32 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -63,12 +63,8 @@ ifdef CONFIG_USER_ONLY
> QEMU_PROG=qemu-$(TARGET_ARCH2)
> else
> # system emulator name
> -ifeq ($(TARGET_ARCH), i386)
> -QEMU_PROG=qemu$(EXESUF)
> -else
> QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
> endif
> -endif
>
> PROGS=$(QEMU_PROG)
>
> @@ -743,6 +739,9 @@ install: all
> ifneq ($(PROGS),)
> 	$(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
> endif
> +ifeq ($(TARGET_ARCH), i386)
> +	ln -sf qemu-system-i386$(EXESUF) "$(DESTDIR)$(bindir)/qemu$(EXESUF)"
> +endif
>
> # Include automatically generated dependency files
> -include $(wildcard *.d */*.d)
> -- 
> 1.6.1.3
>
>
> -- 
> Aurelien Jarno	                        GPG: 1024D/F1BCDB73
> aurelien@aurel32.net                 http://www.aurel32.net
>
>

Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Aurelien Jarno]

On Sat, Apr 18, 2009 at 07:22:20PM +0200, Andreas Färber wrote:
>
> Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:
>
>> For historical reasons, qemu system on i386 is called qemu instead of
>> qemu-system-i386. This seems to confuse users.
>>
>> This patch installs it as qemu-system-i386, and create a compatibility
>> symlink qemu -> qemu-system-i386 as some tools may call it that way.
>> We can change or remove this symlink after a few releases when all the
>> tools have migrated to this new name.
>>
>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
> In general a good idea imo, but don't just assume you can create  
> symlinks on a given file system. Git uses hardlinks and copying as  
> fallbacks iirc.

For hardlinks that's clear. For symlinks, what (file)systems are you
thinking of?

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Stefan Weil]

Aurelien Jarno schrieb:
> On Sat, Apr 18, 2009 at 07:22:20PM +0200, Andreas Färber wrote:
>   
>> Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:
>>
>>     
>>> For historical reasons, qemu system on i386 is called qemu instead of
>>> qemu-system-i386. This seems to confuse users.
>>>
>>> This patch installs it as qemu-system-i386, and create a compatibility
>>> symlink qemu -> qemu-system-i386 as some tools may call it that way.
>>> We can change or remove this symlink after a few releases when all the
>>> tools have migrated to this new name.
>>>
>>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>>>       
>> In general a good idea imo, but don't just assume you can create  
>> symlinks on a given file system. Git uses hardlinks and copying as  
>> fallbacks iirc.
>>     
>
> For hardlinks that's clear. For symlinks, what (file)systems are you
> thinking of?

NTFS?

Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Aurelien Jarno]

On Sat, Apr 18, 2009 at 08:21:09PM +0200, Stefan Weil wrote:
> Aurelien Jarno schrieb:
> > On Sat, Apr 18, 2009 at 07:22:20PM +0200, Andreas Färber wrote:
> >   
> >> Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:
> >>
> >>     
> >>> For historical reasons, qemu system on i386 is called qemu instead of
> >>> qemu-system-i386. This seems to confuse users.
> >>>
> >>> This patch installs it as qemu-system-i386, and create a compatibility
> >>> symlink qemu -> qemu-system-i386 as some tools may call it that way.
> >>> We can change or remove this symlink after a few releases when all the
> >>> tools have migrated to this new name.
> >>>
> >>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> >>>       
> >> In general a good idea imo, but don't just assume you can create  
> >> symlinks on a given file system. Git uses hardlinks and copying as  
> >> fallbacks iirc.
> >>     
> >
> > For hardlinks that's clear. For symlinks, what (file)systems are you
> > thinking of?
> 
> NTFS?

Can someone tries what ln does on such a system? We may do a copy
instead in that case.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Anthony Liguori]

Aurelien Jarno wrote:
> On Sat, Apr 18, 2009 at 08:21:09PM +0200, Stefan Weil wrote:
>   
>> Aurelien Jarno schrieb:
>>     
>>> On Sat, Apr 18, 2009 at 07:22:20PM +0200, Andreas Färber wrote:
>>>   
>>>       
>>>> Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:
>>>>
>>>>     
>>>>         
>>>>> For historical reasons, qemu system on i386 is called qemu instead of
>>>>> qemu-system-i386. This seems to confuse users.
>>>>>
>>>>> This patch installs it as qemu-system-i386, and create a compatibility
>>>>> symlink qemu -> qemu-system-i386 as some tools may call it that way.
>>>>> We can change or remove this symlink after a few releases when all the
>>>>> tools have migrated to this new name.
>>>>>
>>>>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>>>>>       
>>>>>           
>>>> In general a good idea imo, but don't just assume you can create  
>>>> symlinks on a given file system. Git uses hardlinks and copying as  
>>>> fallbacks iirc.
>>>>     
>>>>         
>>> For hardlinks that's clear. For symlinks, what (file)systems are you
>>> thinking of?
>>>       
>> NTFS?
>>     
>
> Can someone tries what ln does on such a system? We may do a copy
> instead in that case.
>   

Windows has a concept of shortcuts (.lnk files).  Cygwin's ln creates a 
shortcut to simulate a symbolic link.  MSYS implements 'ln -s' by doing 
a file copy.  I don't think it works for directories.

I'm not personally opposed to just getting rid of 'qemu' for the 0.11 
release.  Sure, there will be some management tools that look for 'qemu' 
instead of 'qemu-system-i386' but I doubt they'll change things until 
the symlink goes away.

We can issue a big fat ANNOUNCE to the mailing list that for 0.11 the 
executable name will change.  Since it won't be for a few months, that 
should give people time to adjust.

Regards,

Anthony Liguori

Re : [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Sylvain Petreolle]

----- Message d'origine ----
> De : Anthony Liguori <anthony@codemonkey.ws>
> À : qemu-devel@nongnu.org
> Envoyé le : Dimanche, 19 Avril 2009, 0h11mn 49s
> Objet : Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink
> 
> Aurelien Jarno wrote:
> > On Sat, Apr 18, 2009 at 08:21:09PM +0200, Stefan Weil wrote:
> >  
> >> Aurelien Jarno schrieb:
> >>    
> >>> On Sat, Apr 18, 2009 at 07:22:20PM +0200, Andreas Färber wrote:
> >>>        
> >>>> Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:
> >>>> 
> >>>>            
> >>>>> For historical reasons, qemu system on i386 is called qemu instead of
> >>>>> qemu-system-i386. This seems to confuse users.
> >>>>> 
> >>>>> This patch installs it as qemu-system-i386, and create a compatibility
> >>>>> symlink qemu -> qemu-system-i386 as some tools may call it that way.
> >>>>> We can change or remove this symlink after a few releases when all the
> >>>>> tools have migrated to this new name.
> >>>>> 
> >>>>> Signed-off-by: Aurelien Jarno 
> >>>>>                
> >>>> In general a good idea imo, but don't just assume you can create  symlinks 
> on a given file system. Git uses hardlinks and copying as  fallbacks iirc.
> >>>>            
> >>> For hardlinks that's clear. For symlinks, what (file)systems are you
> >>> thinking of?
> >>>      
> >> NTFS?
> >>    
> > 
> > Can someone tries what ln does on such a system? We may do a copy
> > instead in that case.
> >  
> 
> Windows has a concept of shortcuts (.lnk files).  Cygwin's ln creates a shortcut 
> to simulate a symbolic link.  MSYS implements 'ln -s' by doing a file copy.  I 
> don't think it works for directories.
> 
For directories, you have NTFS junctions. 'Linked' directories appear as actual directories in the filesystem.

Re: Re : [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Jamie Lokier]

Sylvain Petreolle wrote:
> > Windows has a concept of shortcuts (.lnk files).  Cygwin's ln
> > creates a shortcut to simulate a symbolic link.  MSYS implements
> > 'ln -s' by doing a file copy.  I don't think it works for
> > directories.
> > 
>
> For directories, you have NTFS junctions. 'Linked' directories
> appear as actual directories in the filesystem.

Windows and NTFS actually have several kinds of link types, resembling
symbolic and hard links, apart from .LNK files and junctions.  They
kept adding more with each version of Windows.

But I doubt if simply losing 'qemu.exe' will cause any great tragedy
for Windows users.

-- Jamie

Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Blue Swirl]

On 4/18/09, Aurelien Jarno <aurelien@aurel32.net> wrote:
> For historical reasons, qemu system on i386 is called qemu instead of
>  qemu-system-i386. This seems to confuse users.
>
>  This patch installs it as qemu-system-i386, and create a compatibility
>  symlink qemu -> qemu-system-i386 as some tools may call it that way.
>  We can change or remove this symlink after a few releases when all the
>  tools have migrated to this new name.

Reasonable change to me too.

>  Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>  ---
>   Makefile.target |    7 +++----
>   1 files changed, 3 insertions(+), 4 deletions(-)
>
>  diff --git a/Makefile.target b/Makefile.target
>  index dae339b..88c7a32 100644
>  --- a/Makefile.target
>  +++ b/Makefile.target
>  @@ -63,12 +63,8 @@ ifdef CONFIG_USER_ONLY
>   QEMU_PROG=qemu-$(TARGET_ARCH2)
>   else
>   # system emulator name
>  -ifeq ($(TARGET_ARCH), i386)
>  -QEMU_PROG=qemu$(EXESUF)
>  -else
>   QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
>   endif
>  -endif
>
>   PROGS=$(QEMU_PROG)
>
>  @@ -743,6 +739,9 @@ install: all
>   ifneq ($(PROGS),)
>         $(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
>   endif
>  +ifeq ($(TARGET_ARCH), i386)
>  +       ln -sf qemu-system-i386$(EXESUF) "$(DESTDIR)$(bindir)/qemu$(EXESUF)"

IIRC '-f' (force) provided by some lns was actually very weak, so
you'd have to use rm first.