From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LvaN2-00084s-7V for qemu-devel@nongnu.org; Sun, 19 Apr 2009 12:59:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LvaMz-00083p-Qz for qemu-devel@nongnu.org; Sun, 19 Apr 2009 12:59:54 -0400 Received: from [199.232.76.173] (port=50418 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvaMz-00083l-H6 for qemu-devel@nongnu.org; Sun, 19 Apr 2009 12:59:53 -0400 Received: from fg-out-1718.google.com ([72.14.220.153]:45705) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LvaMy-0001cR-QS for qemu-devel@nongnu.org; Sun, 19 Apr 2009 12:59:53 -0400 Received: by fg-out-1718.google.com with SMTP id e21so531011fga.8 for ; Sun, 19 Apr 2009 09:59:51 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <49EB4D42.4050206@redhat.com> References: <49EB4D42.4050206@redhat.com> Date: Sun, 19 Apr 2009 19:59:51 +0300 Message-ID: Subject: Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches From: Blue Swirl Content-Type: multipart/mixed; boundary=001485f87bbc990faa0467eb577c Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --001485f87bbc990faa0467eb577c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/19/09, Avi Kivity wrote: > Blue Swirl wrote: > > > Hi, > > > > I gathered a few common complaints about patch submission, hopefully > > not too much affected by my consumption of small amounts of various > > alcoholic substances. > > > > + > > +SP2.3: The description must be followed by one blank line and a > > +"Signed-off-by:" line > > > > A signoff is more than a format; it is a legal declaration, see the Linux > Documentation/SubmittingPatches. It should be clear to the > submitter that this is so. I added this to a new section together with the licensing stuff. > IIRC, one of the requirements is to use your real name :) I can't find such a requirement :) > > + > > +SP3.2: If possible, please send the patch inlined (to make commenting > > +easier) and also attached (to make it easier to apply) > > > > If the patch is attached (and not inlined) it should be marked as > text/plain content type. Added. > > + > > +SP4.4: The patches targeted for development branch must be based on > > +the current development repository > > + > > +SP4.5: The patches targeted for stable branch must be based on the > > +current stable repository > > > > Suggest instead: patches should state which branch they are based on, and > should be based on a recent version of the branch. I'd suppose most of the patches are for the development branch, so one of the subject tags could be "STABLE" indicating stable branch. Without it dev branch is assumed. > In addition: > > When sending multiple patches, patches should be numbered (inside the > brackets: [PATCH 09/17]) and should include a cover letter describing the > patchset in general (as opposed to infividual patch descriptions). Patch > management utilities (git send-email, quilt, and similar) can do this, so > their use is recommended. I collected the patch series stuff to a new section. --001485f87bbc990faa0467eb577c Content-Type: plain/text; name="submitting_patches.diff" Content-Disposition: attachment; filename="submitting_patches.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ftpzesul SW5kZXg6IHFlbXUvU1VCTUlUVElOR19QQVRDSEVTCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIC9kZXYvbnVsbAkx OTcwLTAxLTAxIDAwOjAwOjAwLjAwMDAwMDAwMCArMDAwMAorKysgcWVtdS9TVUJNSVRUSU5HX1BB VENIRVMJMjAwOS0wNC0xOSAxNjo0OToyMC4wMDAwMDAwMDAgKzAwMDAKQEAgLTAsMCArMSwxMTkg QEAKK1doZXJlYXMgdGhlIFFFTVUgZGV2ZWxvcGVycyBoaWdobHkgYXBwcmVjaWF0ZSBhbnkgcGF0 Y2hlcywgaXQgd291bGQgYmUKK21vc3QgaGVscGZ1bCBmb3IgYWxsIHBhcnRpZXMgaWYgdGhlIGZv bGxvd2luZyBydWxlcyB3ZXJlIGZvbGxvd2VkIGluCitvcmRlciB0byBzaW1wbGlmeSBtZWNoYW5p Y2FsIGV4dHJhY3Rpb24gYW5kIGFwcGx5aW5nIG9mIHRoZQorcGF0Y2hlcy4gUGF0Y2ggbWFuYWdl bWVudCB1dGlsaXRpZXMgKGdpdCBzZW5kLWVtYWlsLCBxdWlsdCwgYW5kCitzaW1pbGFyKSBjYW4g YXNzaXN0IGluIHByb2R1Y2luZyBjb21wYXRpYmxlIHBhdGNoZXMgYW5kIHBhdGNoIHNldHMKK3dp dGggY29ycmVjdCBmb3JtYXR0aW5nIGV0Yy4sIHNvIHRoZWlyIHVzZSBpcyByZWNvbW1lbmRlZC4K KworMS4gRm9ybWF0IG9mIGUtbWFpbCBzdWJqZWN0CisKK1NQMS4xOiBUaGUgZS1tYWlsIHN1Ympl Y3QgbXVzdCBjb250YWluICJQQVRDSCIgaW4gYnJhY2tldHMsIGZvbGxvd2VkCitieSB3aGl0ZSBz cGFjZSBhbmQgYSBzaG9ydCBzdW1tYXJ5IG9mIHRoZSBjaGFuZ2UKKworU1AxLjI6IFRoZSBicmFj a2V0ZWQgdGV4dCBtYXkgYWxzbyBpbmNsdWRlIG90aGVyIGNvbW1vbmx5IHVzZWQgdGFncworc2Vw YXJhdGVkIHdpdGggYSBjb21tYSBhbmQgd2hpdGUgc3BhY2UsIGluY2x1ZGluZyAiUkZDIiAoUmVx dWVzdCBmb3IKK0NvbW1lbnRzLCBmb3IgcGF0Y2hlcyBzdWJtaXR0ZWQgZm9yIGRpc2N1c3Npb24g YW5kIHJldmlldyBwdXJwb3Nlcworb25seSkgYW5kICJSRlQiIChSZXF1ZXN0IGZvciBUZXN0aW5n LCBmb3IgcGF0Y2hlcyB3aGljaCBhcmUgc3VzcGVjdGVkCit0byBpbnRyb2R1Y2UgcHJvYmxlbXMg aW4gdXNlIGNhc2VzIHdoaWNoIGhhdmUgbm90IGJlZW4gdGVzdGVkIGJ5IHRoZQorc3VibWl0dGVy KQorCitTUDEuMzogVGhlIHN1bW1hcnkgbXVzdCBiZSBzdWl0YWJsZSBmb3IgY2hhbmdlbG9nIGFz IGlzIChzdGFydCB3aXRoIGEKK2NhcGl0YWwgbGV0dGVyIGV0Yy4pIGFmdGVyIGRlbGV0aW5nIHRo ZSBicmFja2V0ZWQgdGV4dCwgd2hpdGUgc3BhY2UKK2FmdGVyIGl0IGFuZCBhbnkgdGV4dCBwcmVj ZWRpbmcgaXQKKworMi4gRm9ybWF0IG9mIGUtbWFpbCBib2R5CisKK1NQMi4xOiBUaGUgZS1tYWls IGJvZHkgbXVzdCBjb250YWluIGEgZGVzY3JpcHRpb24gb2YgdGhlIGNoYW5nZSwKK3N1aXRhYmxl IGZvciBjaGFuZ2Vsb2cgd2l0aG91dCBhbnkgZWRpdGluZworCitTUDIuMjogVGhlIHBhdGNoIGRl c2NyaXB0aW9uIG11c3QgYmUgc2VsZnN0YW5kaW5nIChub3QgZGVwZW5kIG9uIG90aGVyCitwYXRj aGVzLCBvdGhlciBtZXNzYWdlcyBvciBiYWNrZ3JvdW5kIGRpc2N1c3Npb24pCisKK1NQMi4zOiBU aGUgZGVzY3JpcHRpb24gbXVzdCBiZSBmb2xsb3dlZCBieSBvbmUgYmxhbmsgbGluZSBhbmQgYQor IlNpZ25lZC1vZmYtYnk6IiBsaW5lCisKK1NQMi40OiBPcHRpb25hbGx5LCB0aGUgIlNpZ25lZC1v ZmYtYnk6IiBsaW5lIG1heSBiZSBmb2xsb3dlZCB3aXRoIGEKK2xpbmUgd2l0aCBvbmx5ICItLS0i IGFuZCBvbiB0aGUgZm9sbG93aW5nIGxpbmVzLCBvdGhlciBjb21tZW50cyBub3QKK2ludGVuZGVk IGZvciBjaGFuZ2Vsb2cgKGZvciBleGFtcGxlIGRpZmZzdGF0LCBsb2NhdGlvbiBvZiBhIGdpdCB0 cmVlLAord2hldGhlciB0aGUgcGF0Y2ggaXMgYWxzbyBkaXJlY3RlZCB0b3dhcmRzIHN0YWJsZSB0 cmVlLCB3aXR0eQorc2lnbmF0dXJlIGV0Yy4pCisKK1NQMi41OiBFeGNlcHRpb246IEZvciBleHRy ZW1lbHkgc2hvcnQgYW5kIHRyaXZpYWwgcGF0Y2hlcyAob25lLWxpbmUKK2ZpeGVzIGV0Yy4pLCB0 aGUgZGVzY3JpcHRpb24gYW5kICJTaWduZWQtb2ZmLWJ5OiIgbGluZXMgbWF5IGJlCitvbWl0dGVk LCBpbiB3aGljaCBjYXNlIHRoZSBzdWJqZWN0IG11c3QgYmUgYXBwZW5kZWQgd2l0aCB0aGUKK3N1 Ym1pdHRlcidzIG5hbWUgaW4gcGFyZW50aGVzaXMKKworU1AyLjY6IEV4Y2VwdGlvbjogVGhlIHJ1 bGVzIGluIHRoaXMgc2VjdGlvbiBhcmUgbm90IGFwcGxpY2FibGUgZm9yCitwYXRjaGVzIHRhZ2dl ZCB3aXRoICJSRkMiIG9yICJSRlQiCisKKzMuIEF0dGFjaGluZyBwYXRjaGVzIHRvIGUtbWFpbAor CitTUDMuMTogRWFjaCBtZXNzYWdlIG1heSBjb250YWluIG9ubHkgb25lIHBhdGNoCisKK1NQMy4y OiBJZiBwb3NzaWJsZSwgcGxlYXNlIHNlbmQgdGhlIHBhdGNoIGlubGluZWQgKHRvIG1ha2UgY29t bWVudGluZworZWFzaWVyKSBhbmQgYWxzbyBhdHRhY2hlZCAodG8gbWFrZSBpdCBlYXNpZXIgdG8g YXBwbHkpCisKK1NQMy4yOiBJZiB0aGUgcGF0Y2ggaXMgYXR0YWNoZWQgKGFuZCBub3QgaW5saW5l ZCkgaXQgc2hvdWxkIGJlIG1hcmtlZAorYXMgdGV4dC9wbGFpbiBjb250ZW50IHR5cGUKKworU1Az LjM6IFBsZWFzZSBlbnN1cmUgaW4gYWR2YW5jZSB0aGF0IHlvdXIgZS1tYWlsIHRvb2wgZG9lcyBu b3QgbWFuZ2xlCit3aGl0ZSBzcGFjZSBvciBicmVhayBsb25nIGxpbmVzCisKKzQuIEFib3V0IHBh dGNoZXMKKworU1A0LjE6IEl0IG11c3QgYmUgcG9zc2libGUgdG8gYXBwbHkgdGhlIHBhdGNoIHdp dGggcXVpbHQgKGVxdWl2YWxlbnQKK3RvIHBhdGNoIC1wMSkgYW5kICJnaXQgYW0iIHdpdGhvdXQg YW55IGVkaXRpbmcgb3IgZXh0cmEgZmxhZ3MKKworU1A0LjI6IFRoZSBwYXRjaCBtdXN0IGJlIGlu IHVuaWZpZWQgZGlmZiBmb3JtYXQKKworU1A0LjM6IFRoZSBwYXRjaCBtdXN0IGJlIGJhc2VkIGlu IHRoZSBRRU1VIHJvb3QgZGlyZWN0b3J5IChub3QgZm9yCitleGFtcGxlIEtWTSwgWGVuIG9yIGxv d2VyIGxldmVsIHN1YmRpcmVjdG9yeSkKKworU1A0LjQ6IFRoZSBwYXRjaGVzIHRhcmdldGVkIGZv ciBkZXZlbG9wbWVudCBicmFuY2ggbXVzdCBiZSBiYXNlZCBvbgordGhlIGN1cnJlbnQgZGV2ZWxv cG1lbnQgcmVwb3NpdG9yeQorCitTUDQuNTogVGhlIHBhdGNoZXMgdGFyZ2V0ZWQgZm9yIHN0YWJs ZSBicmFuY2ggbXVzdCBiZSBiYXNlZCBvbiB0aGUKK2N1cnJlbnQgc3RhYmxlIHJlcG9zaXRvcnkK KworNS4gQ2hhbmdlcyBtYWRlIGJ5IHRoZSBwYXRjaAorCitTUDUuMTogRG8gbm90IGNvbWJpbmUg Zm9ybWF0dGluZyBjaGFuZ2VzIHdpdGggZnVuY3Rpb25hbCBjaGFuZ2VzCisKK1NQNS4yOiBEbyBu b3QgY29tYmluZSBzZXZlcmFsIGluZGVwZW5kZW50IGZ1bmN0aW9uYWwgY2hhbmdlcyB0byBvbmUK K3BhdGNoIHVubGVzcyByZXF1aXJlZCBieSB0aGUgbG9naWMgb2YgdGhlIGNoYW5nZXMKKworU1A1 LjM6IFRoZSBjaGFuZ2VzIG1heSBub3QgaW50cm9kdWNlIG5ldyB2aW9sYXRpb25zIG9mIENPRElO R19TVFlMRQorCitTUDUuNDogSWYgdGhlIGNoYW5nZXMgaW52b2x2ZSBuZXcgb3IgY2hhbmdlZCB1 c2VyIGludGVyZmFjZSwKK2RvY3VtZW50YXRpb24gYW5kIGhlbHAgbWVzc2FnZXMgbXVzdCBiZSBj aGFuZ2VkIGFzIHdlbGwKKworU1A1LjU6IElmIHRoZSBjaGFuZ2VzIGFkZCBuZXcgZmlsZXMsIG1h a2Ugc3VyZSB0aGF0IHRoZSBwYXRjaCBpbmNsdWRlcwordGhlbSAoZm9yIGV4YW1wbGUsIHVzZSBk aWZmIGZsYWcgLU4pCisKK1NQNS42IFBsZWFzZSBjaGVjayB0aGF0IHRoZSBjaGFuZ2VzIGRvIG5v dCBpbnRyb2R1Y2UgbmV3IHdhcm5pbmdzIHRvCitiZSBlbWl0dGVkIHdoZW4gY29tcGlsaW5nIHRo ZSBzb3VyY2VzLCBwcmVmZXJhYmx5IG5vdCBldmVuIHdoZW4KK2NvbXBpbGluZyB3aXRoIFNwYXJz ZSBjaGVja2VyCisKKzYuIFNlcmllcyBvZiBwYXRjaGVzCisKK1NQNi4xIFBhdGNoIHNlcmllcyBz aG91bGQgYmUgbnVtYmVyZWQgd2l0aCB0aGUgbnVtYmVyIGluY2x1ZGVkIGluc2lkZQordGhlIGJy YWNrZXRzIGluIHRoZSBzdWJqZWN0IChmb3IgZXhhbXBsZSAiW1BBVENIIDA5LzE3XSIpCisKK1NQ Ni4yOiBUaGUgcGF0Y2ggc2VyaWVzIHNob3VsZCBpbmNsdWRlIGEgY292ZXIgbGV0dGVyIGRlc2Ny aWJpbmcgdGhlCitwYXRjaHNldCBpbiBnZW5lcmFsIChhcyBvcHBvc2VkIHRvIGluZGl2aWR1YWwg cGF0Y2ggZGVzY3JpcHRpb25zKQorCitTUDYuMzogTm8gY2hhbmdlcyBpbiBhIHNpbmdsZSBwYXRj aCBpbiB0aGUgcGF0Y2ggc2VyaWVzIG1heSBicmVhayB0aGUKK2FiaWxpdHkgdG8gYmlzZWN0ICht YWtlIHN1cmUgdGhhdCB3aGVuIGFwcGx5aW5nIHRoZSBwYXRjaGVzCitzZXF1ZW50aWFsbHkgc3Rl cCBieSBzdGVwLCB3b3JraW5nIGV4ZWN1dGFibGVzIGNhbiBiZSBwcm9kdWNlZCBhdCBlYWNoCitz dGVwIGFuZCBub3Qgb25seSBhdCB0aGUgZmluYWwgc3RlcCkKKworCis3LiBMZWdhbCBhc3BlY3Rz CisKK1NQNy4xOiBBbnkgbmV3IGZpbGVzIG9yIG1lcmdlcyBmcm9tIG90aGVyIHNvdXJjZXMgbXVz dCBiZSBsaWNlbmNlZAord2l0aCBsaWNlbmNlcyBjb21wYXRpYmxlIHdpdGggUUVNVSBsaWNlbmNp bmcgKGZvciBleGFtcGxlLCBHUEx2MyBvcgorQ0RETCBhcmUgbm90IGNvbXBhdGlibGUpCisKK1NQ Ny4yOiBUaGUgIlNpZ25lZC1vZmYtYnk6IiBsaW5lIGlzIGEgZm9ybSBvZiBsZWdhbCBkZWNsYXJh dGlvbiB3aGljaAordGhlIHN1Ym1pdHRlciBtdXN0IGJlIGF3YXJlIG9mIChwbGVhc2Ugc2VlIExp bnV4CitEb2N1bWVudGF0aW9uL1N1Ym1pdHRpbmdQYXRjaGVzKQo= --001485f87bbc990faa0467eb577c--