From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches
Date: Mon, 20 Apr 2009 18:29:11 +0300 [thread overview]
Message-ID: <f43fc5580904200829n5761bfc8i78852aa7fe56e8ad@mail.gmail.com> (raw)
In-Reply-To: <49EC8372.9080504@codemonkey.ws>
On 4/20/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Blue Swirl wrote:
>
> > Hi,
> >
> > I gathered a few common complaints about patch submission, hopefully
> > not too much affected by my consumption of small amounts of various
> > alcoholic substances.
> >
> > Comments, objections?
> >
> >
>
>
> > +SP4.1: It must be possible to apply the patch with quilt (equivalent
> > +to patch -p1) and "git am" without any editing or extra flags
> >
>
> svn diff generates -p0 patches so both -p1 and -p0 should be accepted.
Quilt does not accept -p0 patches without extra work. Remember, the
idea is to reduce our burden, make it easier to test and apply
patches.
Diff can generate other types of diffs besides the unified type but we
don't want any other.
next prev parent reply other threads:[~2009-04-20 15:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 15:32 [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches Blue Swirl
2009-04-19 16:11 ` Avi Kivity
2009-04-19 16:59 ` Blue Swirl
2009-04-19 17:36 ` Andreas Färber
2009-04-20 14:19 ` Anthony Liguori
2009-04-19 17:42 ` M. Warner Losh
2009-04-20 8:32 ` Avi Kivity
2009-04-20 15:22 ` Blue Swirl
2009-04-20 18:16 ` Avi Kivity
2009-04-19 16:48 ` [Qemu-devel] " Jan Kiszka
2009-04-19 17:41 ` M. Warner Losh
2009-04-20 7:43 ` Jan Kiszka
2009-04-20 14:23 ` Anthony Liguori
2009-04-19 17:40 ` [Qemu-devel] " M. Warner Losh
2009-04-20 14:13 ` Anthony Liguori
2009-04-20 14:31 ` Avi Kivity
2009-04-20 15:25 ` Blue Swirl
2009-04-20 17:53 ` Anthony Liguori
2009-04-20 14:15 ` Anthony Liguori
2009-04-20 15:29 ` Blue Swirl [this message]
2009-04-20 15:53 ` Kevin Wolf
2009-04-20 16:10 ` Blue Swirl
2009-04-20 15:54 ` François Revol
2009-04-20 16:13 ` Avi Kivity
2009-04-20 18:02 ` Anthony Liguori
2009-04-20 18:12 ` Avi Kivity
2009-04-20 17:59 ` Anthony Liguori
2009-04-20 17:56 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2009-04-19 21:27 Philippe Waille
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580904200829n5761bfc8i78852aa7fe56e8ad@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).