From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LvvQw-0005Jh-Vg
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 11:29:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LvvQp-0005DC-Vw
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 11:29:22 -0400
Received: from [199.232.76.173] (port=49722 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LvvQp-0005Cx-Mo
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 11:29:15 -0400
Received: from mail-bw0-f175.google.com ([209.85.218.175]:60534)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LvvQp-0002Cc-AC
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 11:29:15 -0400
Received: by bwz23 with SMTP id 23so508698bwz.34
	for <qemu-devel@nongnu.org>; Mon, 20 Apr 2009 08:29:13 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <49EC8372.9080504@codemonkey.ws>
References: <f43fc5580904190832g413e67bn494f696a3e3279f4@mail.gmail.com>
	<49EC8372.9080504@codemonkey.ws>
Date: Mon, 20 Apr 2009 18:29:11 +0300
Message-ID: <f43fc5580904200829n5761bfc8i78852aa7fe56e8ad@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for
	submitting patches
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 4/20/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Blue Swirl wrote:
>
> > Hi,
> >
> > I gathered a few common complaints about patch submission, hopefully
> > not too much affected by my consumption of small amounts of various
> > alcoholic substances.
> >
> > Comments, objections?
> >
> >
>
>
> > +SP4.1: It must be possible to apply the patch with quilt (equivalent
> > +to patch -p1) and "git am" without any editing or extra flags
> >
>
>  svn diff generates -p0 patches so both -p1 and -p0 should be accepted.

Quilt does not accept -p0 patches without extra work. Remember, the
idea is to reduce our burden, make it easier to test and apply
patches.

Diff can generate other types of diffs besides the unified type but we
don't want any other.