From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lvw50-0007nx-Pv
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 12:10:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lvw4w-0007hj-68
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 12:10:46 -0400
Received: from [199.232.76.173] (port=45218 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lvw4w-0007hZ-23
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 12:10:42 -0400
Received: from mail-bw0-f175.google.com ([209.85.218.175]:52300)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Lvw4v-0000H7-MT
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 12:10:41 -0400
Received: by bwz23 with SMTP id 23so530292bwz.34
	for <qemu-devel@nongnu.org>; Mon, 20 Apr 2009 09:10:40 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <49EC9A6C.90902@redhat.com>
References: <f43fc5580904190832g413e67bn494f696a3e3279f4@mail.gmail.com>
	<49EC8372.9080504@codemonkey.ws>
	<f43fc5580904200829n5761bfc8i78852aa7fe56e8ad@mail.gmail.com>
	<49EC9A6C.90902@redhat.com>
Date: Mon, 20 Apr 2009 19:10:40 +0300
Message-ID: <f43fc5580904200910i422067efr30336b5189ad9785@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for
	submitting patches
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 4/20/09, Kevin Wolf <kwolf@redhat.com> wrote:
> Blue Swirl schrieb:
>
> > On 4/20/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> >
> > > Blue Swirl wrote:
> > >
> > >
> > > > Hi,
> > > >
> > > > I gathered a few common complaints about patch submission, hopefully
> > > > not too much affected by my consumption of small amounts of various
> > > > alcoholic substances.
> > > >
> > > > Comments, objections?
> > > >
> > > >
> > > >
> > >
> > >
> > > > +SP4.1: It must be possible to apply the patch with quilt (equivalent
> > > > +to patch -p1) and "git am" without any editing or extra flags
> > > >
> > > >
> > >  svn diff generates -p0 patches so both -p1 and -p0 should be accepted.
> > >
> >
> > Quilt does not accept -p0 patches without extra work. Remember, the
> > idea is to reduce our burden, make it easier to test and apply
> > patches.
> >
>
>  I think you'll survive the extra work of adding a -p0 to your series file
> from time to time. Currently SVN is the official solution of qemu and it's
> not obvious how you would create -p1 patches with svn diff. And nowadays
> most patches are generated with git anyway.

If (when?) we switch to git, references to quilt can be dropped and
the whole document can be made much shorter.

Supporting -p0 does not reduce maintainer burden (resulting in
valuable patches getting lost etc.). Making the submitter's life
easier is OK and nice, but that is secondary.