qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Blue Swirl <blauwirbel@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Move block format drivers to new directory 'bdrv'
Date: Sun, 26 Apr 2009 19:18:38 +0300	[thread overview]
Message-ID: <f43fc5580904260918n142000e5u1bdf53b6c7b85e32@mail.gmail.com> (raw)
In-Reply-To: <49F483E8.4050005@redhat.com>

On 4/26/09, Avi Kivity <avi@redhat.com> wrote:
> Christoph Hellwig wrote:
>
> > On Sun, Apr 26, 2009 at 06:19:37PM +0300, Avi Kivity wrote:
> >
> >
> > > Instead of crowding the top-level directory, give block format drivers
> their
> > > very own subdirectory.
> > >
> > >
> >
> > Please also move block.c.  Also block/*.c would match the existing
> > convention, not that I care too much.
> >
> >
>
>  That was deliberate - I wanted to keep the block core in the top level
> directory, and move the block format drivers away.  I'll change it if
> there's consensus that block/*.c (including block.c) is preferable.

Taking one step further, why not introduce directories similar to VirtualBox:
http://www.virtualbox.org/browser/trunk/src/VBox

Or in our style: host/block/, host/net/slirp/, host/usb/,
host/bluetooth/ (trying to match subdirectory names in Linux drivers
directory)?

  reply	other threads:[~2009-04-26 16:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-26 15:19 [Qemu-devel] [PATCH] Move block format drivers to new directory 'bdrv' Avi Kivity
2009-04-26 15:29 ` Christoph Hellwig
2009-04-26 15:55   ` Avi Kivity
2009-04-26 16:18     ` Blue Swirl [this message]
2009-04-26 16:20       ` Avi Kivity
2009-04-26 16:40         ` Blue Swirl
2009-04-26 17:04           ` Avi Kivity
2009-04-26 17:44           ` Anthony Liguori
2009-04-26 17:56             ` Christoph Hellwig
2009-04-26 18:06               ` Avi Kivity
2009-04-26 17:41         ` Anthony Liguori
2009-04-26 18:10           ` Blue Swirl
2009-04-26 21:26             ` Stefan Weil
2009-04-27 12:14             ` Kevin Wolf
2009-04-27 13:52               ` Jamie Lokier
2009-04-27 14:37                 ` M. Warner Losh
2009-04-27 12:08 ` Kevin Wolf
2009-04-27 12:10   ` Avi Kivity
2009-04-27 12:17     ` Kevin Wolf
2009-05-02 10:34   ` Stuart Brady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580904260918n142000e5u1bdf53b6c7b85e32@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=avi@redhat.com \
    --cc=hch@lst.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).