From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ly73w-0005UR-3u for qemu-devel@nongnu.org; Sun, 26 Apr 2009 12:18:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ly73v-0005Tn-Ni for qemu-devel@nongnu.org; Sun, 26 Apr 2009 12:18:39 -0400 Received: from [199.232.76.173] (port=50308 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ly73v-0005Tf-Im for qemu-devel@nongnu.org; Sun, 26 Apr 2009 12:18:39 -0400 Received: from fg-out-1718.google.com ([72.14.220.155]:38272) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ly73v-0005iV-8x for qemu-devel@nongnu.org; Sun, 26 Apr 2009 12:18:39 -0400 Received: by fg-out-1718.google.com with SMTP id e21so412350fga.8 for ; Sun, 26 Apr 2009 09:18:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <49F483E8.4050005@redhat.com> References: <1240759177-27527-1-git-send-email-avi@redhat.com> <20090426152943.GA27812@lst.de> <49F483E8.4050005@redhat.com> Date: Sun, 26 Apr 2009 19:18:38 +0300 Message-ID: Subject: Re: [Qemu-devel] [PATCH] Move block format drivers to new directory 'bdrv' From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Christoph Hellwig , qemu-devel@nongnu.org On 4/26/09, Avi Kivity wrote: > Christoph Hellwig wrote: > > > On Sun, Apr 26, 2009 at 06:19:37PM +0300, Avi Kivity wrote: > > > > > > > Instead of crowding the top-level directory, give block format drivers > their > > > very own subdirectory. > > > > > > > > > > Please also move block.c. Also block/*.c would match the existing > > convention, not that I care too much. > > > > > > That was deliberate - I wanted to keep the block core in the top level > directory, and move the block format drivers away. I'll change it if > there's consensus that block/*.c (including block.c) is preferable. Taking one step further, why not introduce directories similar to VirtualBox: http://www.virtualbox.org/browser/trunk/src/VBox Or in our style: host/block/, host/net/slirp/, host/usb/, host/bluetooth/ (trying to match subdirectory names in Linux drivers directory)?